Skip to content

wait for deps in compose_run #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

doc-sheet
Copy link

Hello.
This PR may be treated as an extra fix for #78
Currently podman compose run starts dependencies but doesn't check for condition requirements.

Could you suggest what test are needed?

Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you also add an integration test?

@doc-sheet
Copy link
Author

Yeah. I'm still testing it.
I found some strange thing with clickhouse healthchecks and don't have much time to investigate.
I don't want to bring breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants