manifest: accept OCI media types in Docker schema2 manifests#2973
Closed
lumincui wants to merge 1 commit into
Closed
manifest: accept OCI media types in Docker schema2 manifests#2973lumincui wants to merge 1 commit into
lumincui wants to merge 1 commit into
Conversation
|
This repository has been migrated to https://github.com/containers/container-libs. Please open your PR there. |
Author
|
This repository has migrated to containers/container-libs, so I moved this PR to podman-container-tools/container-libs#978. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accept OCI image config and layer media types when validating Docker schema 2 manifests.
This allows
Schema2FromManifest/SupportedSchema2MediaTypeto handle Docker schema2 manifests with OCI descriptor media types, includingapplication/vnd.oci.image.layer.v1.tar+gzip.Why
Some registries return Docker schema2 manifests whose config/layer descriptors use OCI media types. Today those fail before copy/inspection can proceed, for example through
skopeo copy --all:Fixes #2972.
Testing
TestSupportedSchema2MediaTypecoverage for OCI config/layer media types.gofmtthroughgolang:1.24container.go test ./manifest -run TestSupportedSchema2MediaType -count=1 -vingolang:1.24, but the container timed out while downloading Go dependencies before reaching test execution in this environment.skopeo v1.23.0build during registry mirroring: manifests with OCI layer media types copied successfully after this change.