CC-41565/41566/41568/41569: stop leaking Kafka record content into logs (v1.16.x backport) - #112
Open
Sahil Sonawane (saheeeel) wants to merge 1 commit into
Open
CC-41565/41566/41568/41569: stop leaking Kafka record content into logs (v1.16.x backport)#112Sahil Sonawane (saheeeel) wants to merge 1 commit into
Sahil Sonawane (saheeeel) wants to merge 1 commit into
Conversation
Sanitize log statements and exception messages so only non-sensitive metadata (field name/path, BSON type, exception type, error codes, counts) reaches INFO/WARN/ERROR logs; full detail is kept at DEBUG/TRACE. DLQ error reporting is unchanged. - CC-41565 MongoProcessedSinkRecordData.tryProcess: log the exception type at ERROR (full exception at DEBUG). Sanitize the CDC throw-site messages (OperationHelper) and UUID id-strategy messages to report BSON type/length, not the value. - CC-41566 StartedMongoSinkTask: drop the driver exception from both LOGGER.error calls; log only exception type, write-error code(s) and counts; full driver detail at DEBUG. - CC-41568 TimeseriesTimeFieldAutoConversion: log field name + exception simple name at INFO; raw DateTimeParseException detail at TRACE. - CC-41569 Validators.errorCheckingPasswordValueValidator: static ERROR message (no driver message / URI) and redacted ConfigException; detail at DEBUG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the CC-41565/41566/41568/41569 log-leak fixes to
v1.16.x(identical change to PR #110 onv2.0.x).Needed because
kafka-connect-firestore-privatebundles & shadesorg.mongodb.kafka:mongo-kafka-connectbuilt from themongo-kafkasubmodule pinned atv1.16.x(1.16.0). v1.16.x doesn't have the fix, so the Firestore connector still leaks record content in logs until this lands.Same 6 files, sanitizing connector log statements (type/code/counts at ERROR, full detail at DEBUG/TRACE); DLQ unchanged. Cherry-picked cleanly (the leak sites are byte-for-byte identical on v1.16.x and v2.0.x).