Pull latest version of image tags when verifying Linux packages #5276
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to pull the latest Docker image tags when verifying Linux packages and makes the repository URL configurable. The changes allow for more flexible package verification by supporting custom repository URLs while ensuring Docker images are up-to-date.
Key changes:
- Added
--pull missingflag to Docker run commands to ensure latest image versions are used - Made
REPOSITORY_BASE_URLoptional with a default value ofhttps://packages.confluent.io - Added a commented-out verification step for Rocky Linux 10
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| service.yml | Adds optional REPOSITORY_BASE_URL parameter with default value |
| packaging/cp/verify-packages.sh | Updates Docker commands to pull missing images and adds placeholder for Rocky Linux 10 |
| .semaphore/verify-linux-packages.yml | Removes hardcoded REPOSITORY_BASE_URL environment variable and uses shell parameter expansion with default value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
service.yml
Outdated
| description: "Base URL of the package repository to verify packages from. | ||
| Defaults to https://packages.confluent.io" |
There was a problem hiding this comment.
The description text is split across two lines with incorrect indentation. The continuation line should be aligned properly or combined into a single line to maintain YAML formatting consistency.
| description: "Base URL of the package repository to verify packages from. | |
| Defaults to https://packages.confluent.io" | |
| description: "Base URL of the package repository to verify packages from. Defaults to https://packages.confluent.io" |
| verify_debian() { | ||
| local version=$2 | ||
| docker run -v $thisdir:/v $1 /v/verify-deb.sh $base_url $version | ||
| docker run --pull missing -v $thisdir:/v $1 /v/verify-deb.sh $base_url $version |
There was a problem hiding this comment.
The Docker volume mount uses an unquoted variable $thisdir. This should be quoted to prevent issues with paths containing spaces: -v "$thisdir:/v".
| verify_rpm() { | ||
| local version=$2 | ||
| docker run -v $thisdir:/v $1 /v/verify-rpm.sh $base_url $version | ||
| docker run --pull missing -v $thisdir:/v $1 /v/verify-rpm.sh $base_url $version |
There was a problem hiding this comment.
The Docker volume mount uses an unquoted variable $thisdir. This should be quoted to prevent issues with paths containing spaces: -v "$thisdir:/v".
Also: configurable repository URL.