Skip to content

Bump storage common and storage common parent version to include hive 2.3.9 fix - #597

Open
blueeldur (BlueEldur) wants to merge 1 commit into
10.0.xfrom
upgradecommon
Open

Bump storage common and storage common parent version to include hive 2.3.9 fix#597
blueeldur (BlueEldur) wants to merge 1 commit into
10.0.xfrom
upgradecommon

Conversation

@BlueEldur

@BlueEldur blueeldur (BlueEldur) commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Problem

Hive 2.3.7 breaks the connector as described #578
We verified the repro and bumped hive in the parent here confluentinc/kafka-connect-storage-common#213

but we didn't upgrade the dependency in the hdfs connector

Solution

bump and realign the dependencies

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

hdfs3 connector

Test Strategy

[INFO] +- io.confluent:kafka-connect-storage-hive🫙10.1.4:compile
[INFO] | +- org.apache.hive.hcatalog:hive-hcatalog-core:jar:2.3.9:compile
[INFO] | | +- org.apache.hive:hive-cli:jar:2.3.9:compile
[INFO] | | | +- org.apache.hive:hive-serde:jar:2.3.9:compile
[INFO] | | | | +- org.apache.hive:hive-service-rpc:jar:2.3.9:compile
[INFO] | | | - org.apache.hive:hive-service:jar:2.3.9:compile
[INFO] | | | +- org.apache.hive:hive-llap-server:jar:2.3.9:compile
[INFO] | | | | +- org.apache.hive:hive-llap-common:test-jar:tests:2.3.9:compile
[INFO] | | +- org.apache.hive:hive-common:jar:2.3.9:compile
[INFO] | | | +- org.apache.hive:hive-storage-api🫙2.4.0:compile
[INFO] | | +- org.apache.hive:hive-metastore:jar:2.3.9:compile
[INFO] | | - org.apache.hadoop:hadoop-archives:jar:2.7.2:compile
[INFO] | +- org.apache.hive:hive-exec:jar:core:2.3.9:compile
[INFO] | | +- org.apache.hive:hive-vector-code-gen:jar:2.3.9:compile
[INFO] | | +- org.apache.hive:hive-llap-tez:jar:2.3.9:compile
[INFO] | | | - org.apache.hive:hive-llap-client:jar:2.3.9:compile
[INFO] | | | - org.apache.hive:hive-llap-common:jar:2.3.9:compile
[INFO] | | +- org.apache.hive:hive-shims:jar:2.3.9:compile
[INFO] | | | +- org.apache.hive.shims:hive-shims-common:jar:2.3.9:compile
[INFO] | | | +- org.apache.hive.shims:hive-shims-0.23:jar:2.3.9:runtime
[INFO] | | | - org.apache.hive.shims:hive-shims-scheduler:jar:2.3.9:runtime

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

backporting to 10.0.x, and releasing both 10.0.x and 10.1.x.

@BlueEldur
blueeldur (BlueEldur) requested a review from a team as a code owner November 23, 2021 03:48
@BlueEldur blueeldur (BlueEldur) changed the title bump common version Bump storage common and storage common parent version to include hive 2.3.9 fix Nov 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaushiksrinivas

Copy link
Copy Markdown

Kalpesh Patel (@kpatelatwork) blueeldur (@BlueEldur)
Is there a plan to commit this fix ?

@BlueEldur

Copy link
Copy Markdown
Contributor Author

kaushiksrinivas Yes there are plans to resolve this, but we haven't quite had the bandwidth yet to investigate why the version bump is breaking ITs yet. We are aware of this breaking issue though. Sorry for the delay.

@kaushiksrinivas

Copy link
Copy Markdown

blueeldur (@BlueEldur) ,
thanks you for the quick response.
Do you have any estimated timeline for this fix to be committed ?

@kaushiksrinivas

Copy link
Copy Markdown

blueeldur (@BlueEldur)
Is there any update on this activity ? this will be needed for hive integrated connect use cases

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@BlueEldur

blueeldur (BlueEldur) commented Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

kaushiksrinivas
The hive 2.3.9 update can now be found in 10.1.x of the hdfs connector. Does your use case require 10.0.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants