Convert org.apache.kafka.connect.data.Date to epoch millis before sending to Elasticsearch - #842
Open
Aleksander Lech (aleksanderlech) wants to merge 1 commit into
Conversation
…och days which is not supported by Elasticsearch
Aleksander Lech (aleksanderlech)
requested a review
from a team
as a code owner
February 26, 2025 07:27
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Author
|
Hello any chance of merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lets consider the following kafka schema:
{ "name": "dateOfBirth", "type": [ "null", {"type": "int", "logicalType": "date"}], "default": null }And the target index field:
Currently the date type (org.apache.kafka.connect.data.Date) is being converted to int (epoch days) and ends up in Elasticsearch being interpreted as epoch millis turning it into some datetime long in the past.
Elasticsearch does not suport epoch days type for
datefields.Solution
Assuming the field is properly indexed as
datewe should pass some of default supported formats likeepoch_millis.Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan
Bugfix, it might be have some incompatibles with existing user workarounds though.