Feat: implementing config key containing many types accepted by kafka #1429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Looking at the configmap, we always have to literally pass a key that is valid for Kafka in string format, that said, why not create a type that contains several constants that will be accepted keys for Kafka?
// Instead of this
c, err :=kafka.NewConsumer(&kafka.ConfigMap{
"bootstrap.servers": "localhost",
"group.id": "myGroup",
"auto.offset.reset": "earliest",
})
//use this
c, err := kafka.NewConsumer(&kafka.ConfigMap{
kafka.BootstrapServers": "localhost",
kafka.GroupId: "myGroup",
kafka.AutoOffsetReset: "earliest",
})
both ways will work in kafka according to the tests I did, so we maintain compatibility both for those who want to write literally and for those who like to have a typing that shows all possible keys.
Checklist
References
JIRA:
None
Test & Review
I tested it with unit tests and modified some small tests