Fix missing upgrade of config requirements in conan lock upgrade
#18481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
changed the title
conan lock upgrade
memsharded
reviewed
Jun 17, 2025
| pass | ||
| if graph_node.conanfile.info and graph_node.conanfile.info.config_version: | ||
| for config_version in graph_node.conanfile.info.config_version._data.keys(): | ||
| self._conf_requires.add(config_version.ref) |
There was a problem hiding this comment.
Broken self._conf_requires.add(config_version.ref)
memsharded
reviewed
Jun 17, 2025
| assert json.loads(c.load("conan.lock"))["config_requires"] == ["config/1.0"] | ||
| c.run("lock remove --config-requires=config/1.0") | ||
|
|
||
| c.run("lock upgrade . --update-config-requires=config/1.0 -cc core.package_id:config_mode=minor_mode") |
There was a problem hiding this comment.
Why the config_mode=minor_mode is relevant here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix missing upgrade of config requirements in
conan lock upgradeDocs: Omit
Closes #18480