Log entry display #1608
Open
Log entry display #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 7, 2025
| return $this->actor; | ||
| } | ||
|
|
||
| public function getTypeTranslationKey(): string |
Contributor
There was a problem hiding this comment.
instead of returning a translation key, I suggest returning a TranslatableInterface (probably using the TranslatableMessage implementation available in core in each case).
The benefits are:
- it will make it possible to use placeholders if needed
- when not using dynamic keys (unlike what it does here), keys can be extracted by the tooling (as it is aware that the constructor of TranslatableMessage takes a translation key)
Member
There was a problem hiding this comment.
I think placeholders aren't really needed here as the types are just fixed strings, and translation key extraction is also kinda useless for this app where we don't really use translations much so we don't have hundreds of keys that are easy to lose track of.. Is there really a point then in changing this?
Seldaek
approved these changes
Nov 8, 2025
Member
Seldaek
left a comment
Seldaek
left a comment
There was a problem hiding this comment.
Leaving open for now as discussion is ongoing, but good to merge IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each audit log type now has its own display class and Twig template in order to display each type in an optimized manner. Also fixes the table layout by adding fixed column widths for date and type.