Allow transfer command to accept a single package name too

Author: stevenrombauts

src/Command/TransferOwnershipCommand.php

@@ -41,7 +41,7 @@ protected function configure(): void
             ->setName('packagist:transfer-ownership')
             ->setDescription('Transfer all packages of a vendor')
             ->setDefinition([
-                new InputArgument('vendor', InputArgument::REQUIRED,'Vendor prefix'),
+                new InputArgument('vendorOrPackage', InputArgument::REQUIRED,'Vendor or package name'),
                 new InputArgument('maintainers', InputArgument::IS_ARRAY|InputArgument::REQUIRED, 'The usernames of the new maintainers'),
                 new InputOption('dry-run', null, InputOption::VALUE_NONE, 'Dry run'),
             ])
@@ -56,17 +56,17 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $output->writeln('ℹ️ DRY RUN');
         }
 
-        $vendor = $input->getArgument('vendor');
+        $vendorOrPackage = $input->getArgument('vendorOrPackage');
         $maintainers = $this->queryAndValidateMaintainers($input, $output);
 
         if (!count($maintainers)) {
             return Command::FAILURE;
         }
 
-        $packages = $this->queryVendorPackages($vendor);
+        $packages = $this->queryPackages($vendorOrPackage);
 
         if (!count($packages)) {
-            $output->writeln(sprintf('<error>No packages found for vendor %s</error>', $vendor));
+            $output->writeln(sprintf('<error>No packages found for %s</error>', $vendorOrPackage));
             return Command::FAILURE;
         }
 
@@ -111,13 +111,20 @@ private function queryAndValidateMaintainers(InputInterface $input, OutputInterf
     /**
      * @return Package[]
      */
-    private function queryVendorPackages(string $vendor): array
+    private function queryPackages(string $vendorOrPackage): array
     {
-        return $this->getEM()
-            ->getRepository(Package::class)
-            ->getFilteredQueryBuilder(['vendor' => $vendor], true)
-            ->getQuery()
-            ->getResult();
+        $repository = $this->getEM()->getRepository(Package::class);
+        $isPackageName = str_contains($vendorOrPackage, '/');
+
+        if ($isPackageName) {
+            $package = $repository->findOneBy(['name' => $vendorOrPackage]);
+
+            return $package ? [$package] : [];
+        }
+
+        return $repository->findBy([
+            'vendor' => $vendorOrPackage
+        ]);
     }
 
     /**
@@ -128,6 +135,8 @@ private function outputPackageTable(OutputInterface $output, array $packages, ar
     {
         $rows = [];
 
+        usort($packages, fn (Package $a, Package $b) => strcasecmp($a->getName(), $b->getName()));
+
         $newMaintainers = array_map(fn (User $user) => $user->getUsername(), $maintainers);
 
         foreach ($packages as $package) {

tests/Command/TransferOwnershipCommandTest.php

@@ -19,6 +19,7 @@
 use App\Entity\User;
 use App\Tests\IntegrationTestCase;
 use Doctrine\Persistence\ManagerRegistry;
+use PHPUnit\Framework\Attributes\TestWith;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Tester\CommandTester;
 
@@ -48,10 +49,10 @@ protected function setUp(): void
         $this->commandTester = new CommandTester($command);
     }
 
-    public function testExecuteSuccessWithAllMaintainersFound(): void
+    public function testExecuteSuccessForVendor(): void
     {
         $this->commandTester->execute([
-            'vendor' => 'vendor1',
+            'vendorOrPackage' => 'vendor1',
             'maintainers' => ['bob', 'alice'],
         ]);
 
@@ -71,17 +72,41 @@ public function testExecuteSuccessWithAllMaintainersFound(): void
         $callable = fn (User $user) => $user->getUsernameCanonical();
         $this->assertEqualsCanonicalizing(['alice', 'bob'], array_map($callable, $package1->getMaintainers()->toArray()));
         $this->assertEqualsCanonicalizing(['alice', 'bob'], array_map($callable, $package2->getMaintainers()->toArray()));
-        $this->assertEqualsCanonicalizing(['john'], array_map($callable, $package3->getMaintainers()->toArray()), 'vendor1 package maintainers should not be changed');
+        $this->assertEqualsCanonicalizing(['john'], array_map($callable, $package3->getMaintainers()->toArray()), 'vendor2 packages should not be changed');
 
         $this->assertAuditLogWasCreated($package1, ['john', 'alice'], ['alice', 'bob']);
         $this->assertAuditLogWasCreated($package2, ['john', 'bob'], ['alice', 'bob']);
+    }
+
+    public function testExecuteSuccessForPackage(): void
+    {
+        $this->commandTester->execute([
+            'vendorOrPackage' => 'vendor2/package1',
+            'maintainers' => ['john', 'alice'],
+        ]);
+
+        $this->commandTester->assertCommandIsSuccessful();
+
+        $em = self::getEM();
+        $em->clear();
+
+        $package2 = $em->find(Package::class, $this->package2->getId());
+        $package3 = $em->find(Package::class, $this->package3->getId());
+
+        $this->assertNotNull($package2);
+        $this->assertNotNull($package3);
+
+        $callable = fn (User $user) => $user->getUsernameCanonical();
+        $this->assertEqualsCanonicalizing(['bob', 'john'], array_map($callable, $package2->getMaintainers()->toArray()), 'vendor1 packages should not be changed');
+        $this->assertEqualsCanonicalizing(['alice', 'john'], array_map($callable, $package3->getMaintainers()->toArray()));
 
+        $this->assertAuditLogWasCreated($package3, ['john'], ['alice', 'john']);
     }
 
     public function testExecuteWithDryRunDoesNothing(): void
     {
         $this->commandTester->execute([
-            'vendor' => 'vendor1',
+            'vendorOrPackage' => 'vendor1',
             'maintainers' => ['alice'],
             '--dry-run' => true,
         ]);
@@ -105,7 +130,7 @@ public function testExecuteWithDryRunDoesNothing(): void
     public function testExecuteFailsWithUnknownMaintainers(): void
     {
         $this->commandTester->execute([
-            'vendor' => 'vendor1',
+            'vendorOrPackage' => 'vendor1',
             'maintainers' => ['unknown1', 'alice', 'unknown2'],
         ]);
 
@@ -118,14 +143,14 @@ public function testExecuteFailsWithUnknownMaintainers(): void
     public function testExecuteFailsIfNoVendorPackagesFound(): void
     {
         $this->commandTester->execute([
-            'vendor' => 'foobar',
+            'vendorOrPackage' => 'foobar',
             'maintainers' => ['bob', 'alice'],
         ]);
 
         $this->assertSame(Command::FAILURE, $this->commandTester->getStatusCode());
 
         $output = $this->commandTester->getDisplay();
-        $this->assertStringContainsString('No packages found for vendor', $output);
+        $this->assertStringContainsString('No packages found for foobar', $output);
     }
 
     /**