Skip to content

Commit 466eed6

Browse files
Use admin as fallback string for actor when transferring packages in bulk
1 parent 7200a78 commit 466eed6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Entity/AuditRecord.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public static function packageTransferred(Package $package, ?User $actor, array
7575
$previous = array_map($callback, $previousMaintainers);
7676
$current = array_map($callback, $currentMaintainers);
7777

78-
return new self(AuditRecordType::PackageTransferred, ['name' => $package->getName(), 'actor' => self::getUserData($actor), 'previous_maintainers' => $previous, 'current_maintainers' => $current], $actor?->getId(), $package->getVendor(), $package->getId());
78+
return new self(AuditRecordType::PackageTransferred, ['name' => $package->getName(), 'actor' => self::getUserData($actor, 'admin'), 'previous_maintainers' => $previous, 'current_maintainers' => $current], $actor?->getId(), $package->getVendor(), $package->getId());
7979
}
8080

8181
public static function versionDeleted(Version $version, ?User $actor): self

tests/Command/TransferOwnershipCommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ private function assertAuditLogWasCreated(Package $package, array $oldMaintainer
141141
]);
142142

143143
$this->assertNotNull($record);
144-
$this->assertSame('unknown', $record->attributes['actor']);
144+
$this->assertSame('admin', $record->attributes['actor']);
145145
$this->assertSame($package->getId(), $record->packageId);
146146

147147
$callable = fn (array $user) => $user['username'];

0 commit comments

Comments
 (0)