-
Notifications
You must be signed in to change notification settings - Fork 37
Add tinyraytracer notebook #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 21 21
Lines 853 853
Branches 87 87
=======================================
Hits 699 699
Misses 154 154 🚀 New features to boost your workflow:
|
|
My comments on this PR are
|
|
Ahh perfect, if I can get rid of this weird license that would be awesome. I'll just get rid of it if that's how it's supposed to work |
9c32875 to
353438b
Compare
|
This is ready from my end if someone can help me with the merge ! |
|
@anutosh491 2 quick questions before I approve.
in the notebook. It feels sufficient that we already pointed the user towards the tutorial series with a link. |
Ahh yess it should just work right ? Haven't given it a shot !
Well this covers step 9 -> I plan to advertise our notebook to the professor behind this once this goes in and have it hosted on his repo -> it has 5k+ stars and good traffic so I'm guessing more students will try it out and report back -> as soon as someone cracks step 10 which is a much better notebook -> we update to step 10 ! |
caa55b2 to
556c776
Compare
Done. |
|
Just approved but I think it should be 'Tiny Ray Tracer using xeus-cpp' and not 'Tiny Ray Tracer in xeus-cpp'. Feel free to merge though if your ok with what it is. |
We had "smallpt in xeus-cpp" if you remember, so probably I just used that :~) |

Description
As the smallpt notebook was removed, I'm taking this chance to add a better example imo here.
Type of change
Please tick all options which are relevant.