-
Notifications
You must be signed in to change notification settings - Fork 36
Use mount instead of preload for tagfiles #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mount instead of preload for tagfiles #336
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
Should probably go in only after the pr using the shared build for xeus. |
f31e89a
to
11ef626
Compare
cc @SylvainCorlay , this should be ready. |
11ef626
to
c802afe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are still preloading these paths in the test executable too
so needs removing there too.
No, for the tests we are not building using jupyter lite build so we can't use empack's mount feature there. The only way we can make it available in the file system is through emscripten's preload, so that remains as it is. If you go through the issue, you will understand that its only xcpp.data that this issue and the pr is concerned about and not any other .data file (which is test_xeus_cpp.data in this case) |
It seems that Matthew's point has been addressed by Anutosh's comment.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes #305
Closes #295
As discussed on the issue
Type of change
Please tick all options which are relevant.