Skip to content

Use mount instead of preload for tagfiles #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

anutosh491
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Fixes #305
Closes #295

As discussed on the issue

  1. xcpp.data should only be responsible for standard headers or resource dir headers
  2. As tagfiles for any 3rd party lib would be expected to be picked up from the prefix, we should do the same for the tagfiles we provide.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (3a888b6) to head (c802afe).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491 anutosh491 requested a review from SylvainCorlay June 6, 2025 05:03
@anutosh491
Copy link
Collaborator Author

Should probably go in only after the pr using the shared build for xeus.

@anutosh491 anutosh491 force-pushed the don't_preload_tags branch 2 times, most recently from f31e89a to 11ef626 Compare June 6, 2025 16:26
@anutosh491
Copy link
Collaborator Author

cc @SylvainCorlay , this should be ready.

@anutosh491 anutosh491 force-pushed the don't_preload_tags branch from 11ef626 to c802afe Compare June 9, 2025 04:15
Copy link
Collaborator

@mcbarton mcbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are still preloading these paths in the test executable too

https://github.com/anutosh491/xeus-cpp/blob/c802afe18f04343157fa036e436e809cd0529aad/test/CMakeLists.txt#L79

so needs removing there too.

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Jun 9, 2025

so needs removing there too.

No, for the tests we are not building using jupyter lite build so we can't use empack's mount feature there.

The only way we can make it available in the file system is through emscripten's preload, so that remains as it is.

If you go through the issue, you will understand that its only xcpp.data that this issue and the pr is concerned about and not any other .data file (which is test_xeus_cpp.data in this case)

@SylvainCorlay SylvainCorlay dismissed mcbarton’s stale review June 10, 2025 05:12

It seems that Matthew's point has been addressed by Anutosh's comment.

@anutosh491 anutosh491 merged commit 703be7d into compiler-research:main Jun 10, 2025
15 checks passed
@anutosh491 anutosh491 deleted the don't_preload_tags branch June 10, 2025 05:42
@anutosh491
Copy link
Collaborator Author

This works as expected

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussing inline documentation/inspect request for lite
4 participants