add GetTemplateInstantiatedFunctions
#642
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup instantated templated functions
vgvassilev
reviewed
Jun 23, 2025
| @@ -863,6 +863,21 @@ void GetFunctionTemplatedDecls(TCppScope_t klass, | |||
| GetClassDecls<FunctionTemplateDecl>(klass, methods); | |||
| } | |||
|
|
|||
| void GetTemplateInstantiatedFunctions(const std::string& name, | |||
There was a problem hiding this comment.
Why would we need all possible instantiations? That encourages iteration other expensive operations.
There was a problem hiding this comment.
Required here.
In cppyy, if there is an instantiation of a templated function, then it is treated as an overloaded function. This also prevents instantiation because we have already extracted the instantiated functions.
There was a problem hiding this comment.
We should avoid iteration. Perhaps we can use some level of FindInstantiation or similar, which does not push everything onto a vector…
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 78.77% 78.82% +0.04%
==========================================
Files 9 9
Lines 3849 3858 +9
==========================================
+ Hits 3032 3041 +9
Misses 817 817
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lookup instantated templated functions
Fixes # (issue)
1 test in cppyy
Type of change
Please tick all options which are relevant.
Testing
Included
Checklist