Fail-fast on prompt_worker crash (prevent “accept but not execute”) #11513
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
We reproduced a scenario where an exception triggers
handle_execution_errorand the code path accesses:class_type = prompt[node_id]["class_type"]If the reported
node_idis modified to a non-existent ID, this lookup can raise (e.g.,KeyError), causing theprompt_workerthread to crash.After that, ComfyUI still appears to accept requests and successfully
putthem into the queue("got prompt" looks normal), but since
prompt_workeris no longer alive, the queue is never consumed.This results in a silent “accept but not execute” state.
This PR is done:
The goal of this PR is to prevent ComfyUI from getting into a state where it accepts requests but does not process them, by adopting a fail-fast that terminates the process immediately.
@comfyanonymous