Skip to content

Code cleanup and automated PEP8 code style check (flake8) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Code cleanup and automated PEP8 code style check (flake8) #62

merged 1 commit into from
Oct 11, 2018

Conversation

pax0r
Copy link
Contributor

@pax0r pax0r commented Oct 10, 2018

Partially solves #52

Mostly automatic code recaftor, but should help you keep with PEP8

@codingo
Copy link
Owner

codingo commented Oct 10, 2018

Thank-you! I'll resolve conflicts for you shortly and merge.

@codingo
Copy link
Owner

codingo commented Oct 10, 2018

Actually, if you don't mind @pax0r - could you resolve the conflicts here? If you compare to master you can see the folder structure change that broke this pull request. I'll continue to tackle #61 in the meantime.

@pax0r
Copy link
Contributor Author

pax0r commented Oct 10, 2018

I did it - FYI read https://www.python.org/dev/peps/pep-0008/ for better Python-like code style :) you can use tool flake8 (http://flake8.pycqa.org/en/latest/) to test code-style on your local machine too. Simply install flake8 with pip and run flake8 command in your project directory. Welcome to the wonderful world of Python :)

@codingo
Copy link
Owner

codingo commented Oct 11, 2018

Thank-you. I am familiar with pep8 / python quite well, this is an old project of mine that's slowly getting a refactor (you can see better examples of this in https://github.com/codingo/vhostscan). Merging this over now but will likely replace these test cases in the future to mirror that of other projects of mine for consistency.

@codingo codingo merged commit 61214c6 into codingo:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants