KAFKA-14691; Add TopicId to OffsetFetch API #4

arvi18 · 2025-04-21T06:47:14Z

WIP

coderabbitai · 2025-04-21T06:47:21Z

Warning

Rate limit exceeded

@arvi18 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ed79212 and 8c11aee.

📒 Files selected for processing (7)

clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java (5 hunks)
clients/src/main/resources/common/message/OffsetFetchRequest.json (2 hunks)
clients/src/main/resources/common/message/OffsetFetchResponse.json (3 hunks)
core/src/main/scala/kafka/server/KafkaApis.scala (4 hunks)
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala (17 hunks)
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java (3 hunks)
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

visz11 · 2025-05-27T09:08:26Z

/codehelper

visz11 · 2025-05-27T09:09:20Z

/codehelper

do-refacto · 2025-05-27T09:14:46Z

core/src/test/scala/unit/kafka/server/KafkaApisTest.scala

@@ -8136,17 +8136,37 @@ class KafkaApisTest extends Logging {
  @ParameterizedTest
  @ApiKeyVersionsSource(apiKey = ApiKeys.OFFSET_FETCH)
  def testHandleOffsetFetchWithMultipleGroups(version: Short): Unit = {
+    val foo = "foo"


Unused variable in test method: The variable bar is declared but not used in this test method. Consider removing it or using it in the test to avoid confusion.

do-refacto · 2025-05-27T09:14:48Z

core/src/main/scala/kafka/server/KafkaApis.scala

@@ -1056,14 +1078,53 @@ class KafkaApis(val requestChannel: RequestChannel,
    offsetFetchRequest: OffsetFetchRequestData.OffsetFetchRequestGroup,


Topic ID Support Version Handling: Please verify that the implementation correctly handles both topic IDs and topic names across different API versions, especially around version 10 which introduces topic ID support. The conditional logic paths based on version checks need careful verification to ensure backward compatibility is maintained.

do-refacto · 2025-05-27T09:14:49Z

core/src/main/scala/kafka/server/KafkaApis.scala

@@ -1040,13 +1042,33 @@ class KafkaApis(val requestChannel: RequestChannel,
        offsetFetchResponse


Authorization Logic with Topic IDs: This section modifies authorization logic to handle topic IDs. Please confirm that authorization checks work properly when using topic IDs instead of topic names, as this is security-critical functionality.

do-refacto · 2025-05-27T09:14:50Z

core/src/test/scala/unit/kafka/server/KafkaApisTest.scala

@@ -8242,21 +8283,169 @@ class KafkaApisTest extends Logging {
        .setGroupId("group-4")


Test Coverage Suggestion: Consider adding specific tests for version compatibility edge cases. The PR adds version-specific behavior for TopicId support (version >= 10), but test coverage for version boundary transitions could be strengthened.

dajac added 5 commits April 18, 2025 14:20

update request/response

775e2eb

update kafkapis

c542dc3

wip

3fdd4e6

tests

5ebe55e

unit test

8c11aee

do-refacto bot reviewed May 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

KAFKA-14691; Add TopicId to OffsetFetch API #4

KAFKA-14691; Add TopicId to OffsetFetch API #4

Uh oh!

arvi18 commented Apr 21, 2025

Uh oh!

coderabbitai bot commented Apr 21, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

visz11 commented May 27, 2025

Uh oh!

visz11 commented May 27, 2025

Uh oh!

do-refacto bot May 27, 2025

Uh oh!

do-refacto bot May 27, 2025

Uh oh!

do-refacto bot May 27, 2025

Uh oh!

do-refacto bot May 27, 2025

Uh oh!

Uh oh!

		@@ -1056,14 +1078,53 @@ class KafkaApis(val requestChannel: RequestChannel,
		offsetFetchRequest: OffsetFetchRequestData.OffsetFetchRequestGroup,

		@@ -1040,13 +1042,33 @@ class KafkaApis(val requestChannel: RequestChannel,
		offsetFetchResponse

		@@ -8242,21 +8283,169 @@ class KafkaApisTest extends Logging {
		.setGroupId("group-4")

KAFKA-14691; Add TopicId to OffsetFetch API #4

Are you sure you want to change the base?

KAFKA-14691; Add TopicId to OffsetFetch API #4

Uh oh!

Conversation

arvi18 commented Apr 21, 2025

Uh oh!

coderabbitai bot commented Apr 21, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

visz11 commented May 27, 2025

Uh oh!

visz11 commented May 27, 2025

Uh oh!

do-refacto bot May 27, 2025

Choose a reason for hiding this comment

Uh oh!

do-refacto bot May 27, 2025

Choose a reason for hiding this comment

Uh oh!

do-refacto bot May 27, 2025

Choose a reason for hiding this comment

Uh oh!

do-refacto bot May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)