ci: add shellcheck step #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ShellCheck as npm dependency (v4.1.0) - Create shellcheck_validate.sh script with paths-filter integration - Add .shellcheckrc configuration file with Terraform-specific disables - Integrate ShellCheck step into CI workflow - Use selective validation based on changed files
Fix ShellCheck warnings across all shell scripts: - SC2155: Separate variable declaration and assignment to avoid masking return values - SC2068: Quote array expansions to prevent word splitting - SC2164: Add error handling to cd commands with || exit - SC2088: Replace tilde with $HOME for proper expansion in quotes - SC2206: Use robust array assignment with IFS read instead of word splitting - SC1090: Add disable directive for non-constant source paths All changes preserve or improve functionality while following shell scripting best practices.
- Added new shellcheck disables for Terraform syntax in .shellcheckrc. - Enhanced quoting in start.sh and codex scripts to prevent word splitting and globbing issues. - Updated shellcheck validation script to exclude .terraform directory from checks.
matifali
approved these changes
Nov 25, 2025
Contributor
Author
|
we should be good here now. |
matifali
approved these changes
Nov 26, 2025
Contributor
Author
|
sorry @matifali I had to update the module versions again because of mainline commits. |
matifali
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.