chore: remove maintainer_github from all modules and examples #231
Conversation
|
Also, can we add a linter rule to ensure there are no erroneous frontmatter entries? |
There was a problem hiding this comment.
Going to defer to @bcpeinhardt for final approval, since he's got a lot more context for the Registry site's build step, but I cross-referenced all the tags in the PR description with the changes in the PR, and everything looks good to me
Only thing is, I think we can actually go a bit further with our changes:
- I want to say we should be clear to remove the
partner_githubfield as well, since it andmaintainer_githubwere both officially deprecated, and we've switched to a different publishing system. That would affect:hcp-vault-secretsjfrog-oauthjfrog-tokenvault-githubvault-jwtvault-token
- All the non-Coder modules still have a
maintainer_githubfield - The
MAINTAINER.mdfile should be updated to remove any mention ofmaintainer_github, and (hopefully)partner_github, too
Yup this looks aligned with registry-servers build process 😎 I agree with all of @Parkreiner 's suggestions though. Ideally those would go on this PR too. The real source of truth for the frontmatter content can be seen here: https://github.com/coder/registry-server/blob/main/sdk/codegentypes/frontmattertypes.go |
I was ironically just thinking about how I could avoid having to tag and push all of these modules individually XD |
I totally agree with removing partner_github, I was just waiting on someone to confirm that we aren't using this on the frontend anywhere since JFrog and Hashicorp modules have this field set. |
|
@Parkreiner and @bcpeinhardt, we might need some other way to mark some modules as partner-certified in the future. There is no immidiate need but it is a valid request from Partnserhips. |
So are we wanting to push this without the removals of I was holding on this till I had a answer on it. |
@matifali ant thoughts on this or should this be good to go in its current form? I was waiting on confirmation that removing partner_github from Jfrog or HCP to make sure it nothing is using it currently |
|
Let's remove this too @DevelopmentCats |
I'll get this done today and merged |
This PR updates all modules to remove maintainer_github field from frontmatter.
I also updated a few modules to 1.0.31 to be later than the latest general release on coder/modules.
All of these modules have not been tagged since the move from coder/modules. I believe they all need to move to 1.0.31 to outpace the latest published general version from coder/modules.
Modules Updated: