🤖 fix: restore DirectoryPickerModal in ProjectCreateModal #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #637 accidentally removed the DirectoryPickerModal integration that was added in PR #682. This restores: - Desktop mode: native pickDirectory() dialog - Browser mode: web-based DirectoryPickerModal component - Conditional Browse button based on platform capabilities - Theme-aware styling (text-foreground instead of hardcoded text-white) Also adds ProjectCreateModal.stories.tsx with 8 Storybook tests covering: - Basic modal rendering - Typing path manually - Browse button opening directory picker - Directory navigation - Path selection flow - Full end-to-end flow - Cancel behavior - Validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #637 accidentally removed the DirectoryPickerModal integration added in PR #682.
Changes
ProjectCreateModal.tsx:
pickDirectory()dialogDirectoryPickerModalcomponenttext-foregroundinstead of hardcodedtext-white)ProjectCreateModal.stories.tsx (new):
Generated with
mux