Skip to content

refactor: add assert() for PHPStan #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 26, 2024

Description

Error: Binary operation "%" between string and non-empty-string&numeric-string results in an error.
 ------ ------------------------------------------------------ 
  Line   src/CronExpression.php                                
 ------ ------------------------------------------------------ 
  154    Binary operation "%" between string and               
         non-empty-string&numeric-string results in an error.  
 ------ ------------------------------------------------------ 

https://github.com/codeigniter4/tasks/actions/runs/10093662663/job/27909864651?pr=171

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10105577918

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.676%

Totals Coverage Status
Change from base Build 9986768704: 0.0%
Covered Lines: 336
Relevant Lines: 444

💛 - Coveralls

@kenjis kenjis merged commit 0bc1137 into codeigniter4:develop Jul 28, 2024
31 of 32 checks passed
@kenjis kenjis deleted the fix-phpstan-error branch July 28, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants