-
Notifications
You must be signed in to change notification settings - Fork 17
cf_install for all dep managers #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
return "uv sync --all-extras" | ||
return """| | ||
uv sync --all-extras | ||
uv pip install codeflash""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is expected that codeflash is already added in the dev time dependency. We should not re-install codeflash...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try doing 'uv run' with absolute path? the path you get after running which codeflash
@@ -490,9 +490,12 @@ def get_dependency_installation_commands(dep_manager: DependencyManager) -> tupl | |||
return """| | |||
python -m pip install --upgrade pip | |||
pip install poetry | |||
poetry install --all-extras""" | |||
poetry install --all-extras | |||
poetry add codeflash""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this modifies the dependencies spec, and adds codeflash in the required set of dependencies. This is wrong to do in the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it wrong to do so?
User description
Next Error : - We should be trying to check if test directory is available or create one to avoid this error.
INFO Logging level set to INFO
────────────────────────────────────────────────────────────────────────────────
Traceback (most recent call last):
File "/home/runner/work/Python/Python/.venv/bin/codeflash", line 10, in
sys.exit(main())
~~~~^^
File "/home/runner/work/Python/Python/.venv/lib/python3.13/site-packages/codeflash/main.py", line 37, in main
args = process_pyproject_config(args)
File "/home/runner/work/Python/Python/.venv/lib/python3.13/site-packages/codeflash/cli_cmds/cli.py", line 129, in process_pyproject_config
assert Path(args.tests_root).is_dir(), f"--tests-root {args.tests_root} must be a valid directory"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
AssertionError: --tests-root /home/runner/work/Python/Python/tests must be a valid directory
PR Type
Description
Standardize formatting and spacing in function definitions.
Enhance dependency installation commands for Poetry.
Enhance dependency installation commands for uv.
Add automatic installation of codeflash package.
Changes walkthrough 📝
cmd_init.py
Update dependency installation commands with codeflash add.
codeflash/cli_cmds/cmd_init.py