-
Notifications
You must be signed in to change notification settings - Fork 18
disable concolic testing in LSP mode #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
||
@lru_cache(maxsize=1) | ||
def is_LSP_enabled() -> bool: | ||
return console.quiet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Isnt it redundant as we already have it in main function in beta.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, console.quiet by default is False, beta.py sets it to True & this function let's other parts of the codebase when it's been set to true.
@@ -182,6 +182,7 @@ def optimize_python_code_line_profiler( # noqa: D417 | |||
"python_version": platform.python_version(), | |||
"experiment_metadata": experiment_metadata, | |||
"codeflash_version": codeflash_version, | |||
"lsp_mode": is_LSP_enabled(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: What changes in aiservices are we thinking to change for LSP server?
No of candidates and tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently we only limit the number of line profiler candidates to 5, the aiservice already is ready for this change
PR Type
Enhancement
Description
Add is_LSP_enabled utility for LSP detection
Skip concolic test generation in LSP mode
Include lsp_mode flag in API requests
Adjust imports for console usage
Changes walkthrough 📝
aiservice.py
Add LSP flag to API optimizer payload
codeflash/api/aiservice.py
is_LSP_enabled
from env_utilslsp_mode
flag to optimizer payloadenv_utils.py
Introduce is_LSP_enabled utility
codeflash/code_utils/env_utils.py
is_LSP_enabled
functionconcolic_testing.py
Skip concolic tests under LSP mode
codeflash/verification/concolic_testing.py
is_LSP_enabled