[FIX] Circular dependency and global assignments imports

[mohammedahmed18]

Description

This fixes two issues

• circular dependency, which can happen if some object in a module is referenced in the same module and also is imported in the optimized code context like here

• imports of the global assignments are not included in the module if they weren't used before adding them, which result in a fatal error when running the tests, fixed just by adding the global assignments before adding the imports, not the opposite

Changes walkthrough 📝

	Relevant files
Bug fix	code_extractor.py Skip same-module imports to prevent circular references    codeflash/code_utils/code_extractor.py Added condition to skip imports when dst_context.full_module_name equals module Consolidated import checks into improved if statement +4/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review String Comparison Use == instead of is when comparing dst_context.full_module_name to mod to avoid unintended behavior from string interning. if ( f"{mod}.{obj}" in helper_functions_fqn or dst_context.full_module_name is mod # avoid circular imports ): Missing Tests There are no tests validating the new skip logic for helper functions or circular imports. Add tests to ensure imports are correctly skipped when expected. if ( f"{mod}.{obj}" in helper_functions_fqn or dst_context.full_module_name is mod # avoid circular imports ): continue # Skip adding imports for helper functions already in the context AddImportsVisitor.add_needed_import(dst_context, mod, obj) RemoveImportsVisitor.remove_unused_import(dst_context, mod, obj)

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Use == for string comparison Use value comparison instead of identity when checking module names to avoid unpredictable behavior. Replace is with == for string comparison. codeflash/code_utils/code_extractor.py [334-338] if ( f"{mod}.{obj}" in helper_functions_fqn - or dst_context.full_module_name is mod # avoid circular imports + or dst_context.full_module_name == mod # avoid circular imports ): continue # Skip adding imports for helper functions already in the context Suggestion importance[1-10]: 8 __ Why: The code uses is to compare strings, which can lead to unpredictable behavior; using == ensures correct string comparison.	Medium

[misrasaurabh1]

Very cool! Thanks for looking into this. Can you add a test for this that would fail before this change and then passes after this change?

[misrasaurabh1]

prefer == over is

[misrasaurabh1]

awesome, thanks