Skip to content

concolic time from 64 to 20s per condition #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

misrasaurabh1
Copy link
Contributor

@misrasaurabh1 misrasaurabh1 commented Jun 26, 2025

PR Type

Enhancement


Description

  • Reduce per-condition timeout from 64s to 20s

  • Speed up concolic test execution


Changes walkthrough 📝

Relevant files
Configuration changes
concolic_testing.py
Lower per-condition timeout value                                               

codeflash/verification/concolic_testing.py

  • Lower default per-condition timeout from 64 to 20 seconds
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Timeout Adjustment

    Reducing the per-condition timeout from 64s to 20s may lead to premature timeouts during concolic execution; ensure this shorter duration suffices for all target conditions.

    "--per_condition_timeout=20",

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Extract timeout into constant

    Extract the hard-coded timeout value into a named constant to avoid a magic number
    and improve readability. Use an f-string to insert the constant into the subprocess
    argument.

    codeflash/verification/concolic_testing.py [46]

    -"--per_condition_timeout=20",
    +f"--per_condition_timeout={PER_CONDITION_TIMEOUT}",
    Suggestion importance[1-10]: 5

    __

    Why: Extracting the magic timeout value into PER_CONDITION_TIMEOUT improves readability and maintainability by avoiding hard‐coded values without altering functionality.

    Low

    @misrasaurabh1 misrasaurabh1 enabled auto-merge June 26, 2025 23:53
    Copy link
    Contributor

    @Saga4 Saga4 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Q: How did we bring down the time for concolic testing?

    @misrasaurabh1 misrasaurabh1 merged commit 9c0fa45 into main Jun 27, 2025
    16 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants