⚡️ Speed up function sorter
by 183,490%
#346
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 183,490% (1,834.90x) speedup for
sorter
incode_to_optimize/bubble_sort.py
⏱️ Runtime :
3.33 seconds
→1.81 milliseconds
(best of542
runs)📝 Explanation and details
Here’s a much faster rewrite of your
sorter
function. Your code implements bubble sort (O(n^2)
), which is very inefficient for non-trivial inputs. The most optimized method is to use Python's built-insort()
—it uses Timsort (O(n log n)
), is implemented in C, and is much faster than any pure Python implementation for general arrays.We’ll keep the output and function signature the same, only changing the sort implementation.
Notes:
.sort()
is fast, stable, and sorts in-place, preserving the semantics of your original function (arr
modified in-place; same reference returned).This will dramatically improve performance for all but tiny arrays.
✅ Correctness verification report:
⚙️ Existing Unit Tests and Runtime
benchmarks/test_benchmark_bubble_sort.py::test_sort2
test_bubble_sort.py::test_sort
test_bubble_sort_conditional.py::test_sort
test_bubble_sort_import.py::test_sort
test_bubble_sort_in_class.py::TestSorter.test_sort_in_pytest_class
test_bubble_sort_parametrized.py::test_sort_parametrized
test_bubble_sort_parametrized_loop.py::test_sort_loop_parametrized
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-sorter-mc2ibb75
and push.