-
Notifications
You must be signed in to change notification settings - Fork 17
Custom Benchmark fixture for running benchmark tests when the pytest-benchmark plugin is disabled #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aseembits93
wants to merge
14
commits into
main
Choose a base branch
from
benchmark-fixture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Custom Benchmark fixture for running benchmark tests when the pytest-benchmark plugin is disabled #302
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
56108b5
need to fix precommit errors
aseembits93 5b68810
rename
aseembits93 c92da49
works
aseembits93 5220b5e
bugfix
aseembits93 aa33d77
Merge branch 'main' into benchmark-fixture
aseembits93 a4b204d
ready to review
aseembits93 3c76a95
Merge branch 'main' into benchmark-fixture
aseembits93 c1f36ac
Update test_runner.py
aseembits93 76603f2
Merge branch 'main' into benchmark-fixture
aseembits93 f030f41
precommit fix
aseembits93 3373197
precommit fix
aseembits93 fa75373
Merge branch 'main' into benchmark-fixture
aseembits93 84fa47d
Merge branch 'main' into benchmark-fixture
aseembits93 07356f1
Merge branch 'main' into benchmark-fixture
aseembits93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
from typing import Any, Callable, Optional | ||
|
||
import pytest | ||
|
||
|
||
def pytest_configure(config) -> None: # noqa: ANN001 | ||
config.addinivalue_line("markers", "benchmark") | ||
|
||
|
||
@pytest.fixture | ||
def benchmark(request): # noqa: ANN201, ANN001 | ||
class CustomBenchmark: | ||
def __init__(self) -> None: | ||
self.stats = [] | ||
|
||
def __call__(self, func, *args, **kwargs): # noqa: ANN204, ANN001, ANN002, ANN003 | ||
# Just call the function without measuring anything | ||
return func(*args, **kwargs) | ||
|
||
def __getattr__(self, name): # noqa: ANN204, ANN001 | ||
# Return a no-op callable for any attribute | ||
return lambda *args, **kwargs: None # noqa: ARG005 | ||
|
||
def pedantic( | ||
self, | ||
target: Callable, | ||
args: tuple = (), | ||
kwargs: Optional[dict] = None, # noqa: FA100 | ||
iterations: int = 1, # noqa: ARG002 | ||
rounds: int = 1, # noqa: ARG002 | ||
warmup_rounds: int = 0, # noqa: ARG002 | ||
setup: Optional[Callable] = None, # noqa: FA100 | ||
) -> Any: # noqa: ANN401 | ||
"""Mimics the pedantic method of pytest-benchmark.""" | ||
if setup: | ||
setup() | ||
if kwargs is None: | ||
kwargs = {} | ||
return target(*args, **kwargs) | ||
|
||
@property | ||
def group(self): # noqa: ANN202 | ||
"""Return a dummy group object.""" | ||
return type("Group", (), {"name": "dummy"})() | ||
|
||
@property | ||
def name(self) -> str: | ||
"""Return a dummy name.""" | ||
return "dummy_benchmark" | ||
|
||
@property | ||
def fullname(self) -> str: | ||
"""Return a dummy fullname.""" | ||
return "dummy::benchmark" | ||
|
||
@property | ||
def params(self): # noqa: ANN202 | ||
"""Return empty params.""" | ||
return {} | ||
|
||
@property | ||
def extra_info(self): # noqa: ANN202 | ||
"""Return empty extra info.""" | ||
return {} | ||
|
||
# Check if benchmark fixture is already available (pytest-benchmark is active) | ||
if "benchmark" in request.fixturenames and hasattr(request, "_fixturemanager"): | ||
try: | ||
# Try to get the real benchmark fixture | ||
return request.getfixturevalue("benchmark") | ||
except (pytest.FixtureLookupError, AttributeError): | ||
pass | ||
custom_benchmark = CustomBenchmark() | ||
if request.node.get_closest_marker("benchmark"): | ||
# Return our custom benchmark for tests marked with @pytest.mark.benchmark | ||
return custom_benchmark | ||
return custom_benchmark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.