Skip to content

Add Java support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2024
Merged

Add Java support #5

merged 9 commits into from
Jun 5, 2024

Conversation

glokta1
Copy link
Contributor

@glokta1 glokta1 commented Jun 4, 2024

No description provided.

Copy link

linear bot commented Jun 4, 2024

@glokta1 glokta1 requested a review from rohitpaulk June 5, 2024 08:55
@@ -3,7 +3,10 @@
This is a starting point for Go solutions to the
["Build Your Own Shell" Challenge](https://app.codecrafters.io/courses/shell/overview).

_Add a description of your course here_
_In this challenge, you'll build your own POSIX compliant shell that's capable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same as others - remove italics)

// You can use print statements as follows for debugging, they'll be visible when running tests.
System.out.println("Logs from your program will appear here!");

System.out.print("$ ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the prompt inside the commented bit like other challenges do:

Screenshot 2024-06-05 at 11 56 04

@@ -0,0 +1,9 @@
import java.util.Scanner;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation

@glokta1 glokta1 merged commit a2bccc7 into main Jun 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants