Skip to content

Add support for Javascript #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Add support for Javascript #4

merged 5 commits into from
Jun 5, 2024

Conversation

glokta1
Copy link
Contributor

@glokta1 glokta1 commented Jun 4, 2024

No description provided.

Copy link

linear bot commented Jun 4, 2024

@glokta1 glokta1 requested a review from rohitpaulk June 4, 2024 08:08
This is a starting point for JavaScript solutions to the
["Build Your Own Shell" Challenge](https://app.codecrafters.io/courses/shell/overview).

_Add a description of your course here_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glokta1 let's pay more attention and thoroughly read a PR diff before opening for review. Let's fix this - copy description from https://app.codecrafters.io/courses/shell/overview.

Copy link
Member

@rohitpaulk rohitpaulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove readline

@glokta1 glokta1 requested a review from rohitpaulk June 5, 2024 08:15
@@ -3,7 +3,10 @@
This is a starting point for Go solutions to the
["Build Your Own Shell" Challenge](https://app.codecrafters.io/courses/shell/overview).

_Add a description of your course here_
_In this challenge, you'll build your own POSIX compliant shell that's capable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in other PR, leaving a note here too - remove italics

@glokta1 glokta1 merged commit 1c259c3 into main Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants