-
-
Notifications
You must be signed in to change notification settings - Fork 121
Upgrade all dependencies #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: rhengles <[email protected]>
Co-authored-by: rhengles <[email protected]>
Co-authored-by: rhengles <[email protected]>
…roller Co-authored-by: rhengles <[email protected]>
|
For those that want to use this, the fork is available at NPM: https://www.npmjs.com/package/@arijs/tweakpane |
|
Thank you for the PR. Regular updates of dependencies are certainly important. However, the scope of changes in this PR is too broad. This makes it difficult to review thoroughly, increases the risk of missing bugs, and significantly raises the verification cost. Please divide the changes into smaller, focused units (e.g., linter-related updates). Avoid combining unrelated changes in a single PR. |
|
I understand your concerns, but besides the changes in the package.json files, the changes in the other files were the absolute minimum needed to clear all errors and warnings during the builds/tests/linting. The tests should provide sufficient/enough confidence that the project as a whole is still working, and I did some basic manual testing and didn't find any issues. The changes in the other files are due to:
If there's any remaining questions, I'd be happy to answer. |
|
Thank you for the detailed explanation. That said, I'm ultimately responsible for the product's quality assurance. If any issue arises after merging this PR, I'll be the one who has to investigate and resolve it. This means I need to verify ALL behaviors myself, regardless of the level of testing you've already performed. I can see why you might want to update everything at once. However, as mentioned earlier, this PR includes unrelated changes that make it unnecessarily large in scope. At the moment, I don't have enough resources for maintenance, so I'd like to keep the review effort minimal. Please break down the changes into the smallest possible units. |
Upgrade all dependencies to latest stable versions
Summary
Successfully upgraded all dependencies and devDependencies to their latest stable versions across all 4 package.json files in the monorepo. All builds, lints, and tests passing with zero vulnerabilities.
Packages Updated
package.json): 23 dependencies upgradedpackages/core/package.json): No devDependencies (inherits from root)packages/tweakpane/package.json): 13 dependencies upgradedpackages/tweakpane/test-module/package.json): 7 dependencies upgradedMajor Version Upgrades Requiring Attention⚠️
ESLint v7 → v9
.eslintrc.jsto flat configeslint.config.js@typescript-eslint/eslint-pluginv5 → v8@typescript-eslint/parserv5 → v8typescript-eslintunified package v8.46.2@eslint/jsv9.38.0@typescript-eslint/ban-types→@typescript-eslint/no-unsafe-function-type)Prettier v2 → v3
Rollup v2 → v4
rollup-plugin-terserv7.0.2 (deprecated)@rollup/plugin-terserv0.4.4@rollup/plugin-*packages to v12-16 rangeimport Package from './package.json' with { type: 'json' };{terser as Terser}to defaultterserMocha v10 → v11⚠️
--require ts-node/registerflag from test commands (conflicted with--loader=ts-node/esmin Mocha v11)glob v7 → v11
Glob.sync()toglobSync()named exportdoc-build-html.js,assets-version.jsTypeScript v4 → v5
Other Major Updates
autoprefixerv9.1.5 → v10.4.21canvasv2.9.1 → v3.2.0jsdomv16.7.0 → v27.0.1@types/jsdomv16.2.13 → v27.0.0mkdirpv1.0.4 → v3.0.1nycv15.1.0 → v17.1.0rimrafv3.0.2 → v6.0.1sassv1.58.0 → v1.93.2postcssv8.2.6 → v8.5.6postcss-cliv8.3.1 → v11.0.1typedocv0.23.24 → v0.28.14typedoc-plugin-missing-exportsv1.0.0 → v4.1.2@types/nodev10.12.18 → v24.9.2@types/mochav9.1.1 → v10.0.10ts-nodev10.9.1 → v10.9.2tslibv2.1.0 → v2.8.1typescriptv4.9.5 → v5.9.3Testing Status
✅ All builds passing (core + tweakpane + docs)
✅ All lints passing (SCSS + TypeScript)
✅ All unit tests passing:
✅ Module integration tests passing
✅ Coverage tests passing
✅ npm audit: 0 vulnerabilities
Compatibility Notes
Files Changed
eslint.config.js, removed.eslintrc.jsOriginal prompt
This pull request was created as a result of the following prompt from Copilot chat.