Open
Conversation
|
You can preview your changes by visiting this link. Note This feature is still experimental and may not work as expected in some cases. Please report any issues you find! |
Signed-off-by: Alan Pope <alan.pope@anchore.com>
Contributor
Author
|
Looking good! 😅
|
Contributor
|
I'd hold on merging this because I'm not sure what other parts of CNCF infra may rely on those logos (even if they aren't referenced directly in the landscape.yml). I'll do some research post kubecon with the team |
Contributor
Author
|
Very wise; no worries. I did have a rummage and certainly found one or two deep links to images, but not many. Obviously, there may be more links in repos outside the cncf.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to fix #4316
I ran this script which lists out the files that are orphaned (with
rmin front of them). This is the result of removing those orphaned logos.Fingers crossed I deleted the right ones!