Merged
Conversation
Doesn't handle file lookup yet. Also, metadata diffs based on metadata.json not yet implemented in previous PR to work here
…vessel into refactor/parse-diffoscope
sei-aderr
commented
Sep 11, 2025
sei-lzhan
reviewed
Sep 12, 2025
sei-secheverria
requested changes
Sep 12, 2025
Contributor
sei-secheverria
left a comment
There was a problem hiding this comment.
Very good improvements, several comments below
Contributor
Author
|
Consider renaming |
Contributor
Author
|
Ready for another review. Lihan fixed the other tests in |
Contributor
|
diff_command unit test fixed, ready for review |
sei-secheverria
requested changes
Sep 17, 2025
Contributor
sei-secheverria
left a comment
There was a problem hiding this comment.
Looks good, a couple of very minor points
sei-secheverria
approved these changes
Sep 18, 2025
sei-kpitstick
approved these changes
Sep 22, 2025
Contributor
sei-kpitstick
left a comment
There was a problem hiding this comment.
Tested, results line up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of
parse_diffoscope_jsonfunction. Mainly followed the suggestions from Sebastian from a while ago that I saved in the issue_check_flagsfunction, and made each separate check into its own function_process_and_save_resultsto_process_and_write_resultsis_pathtois_abs_pathand added testsparent_sourceparameters and class variables fromDiffWould appreciate a quick review of how it looks now, to see if there are other changes that should be made before I write unit tests for each sub function if they were to change.