Skip to content
This repository was archived by the owner on Oct 19, 2021. It is now read-only.

Add prefer_logical_operator rule#545

Open
berrberr wants to merge 2 commits intoclutchski:masterfrom
berrberr:add-prefer-logical-operator
Open

Add prefer_logical_operator rule#545
berrberr wants to merge 2 commits intoclutchski:masterfrom
berrberr:add-prefer-logical-operator

Conversation

@berrberr
Copy link

This rule is essentially the inverse of prefer_english_operator.

@berrberr berrberr changed the title Add prefer_logical_operator rule. Add prefer_logical_operator rule Jan 25, 2016
lintToken: (token, tokenApi) ->
# console.log "lintToken :: ", token
config = tokenApi.config[@rule.name]
level = config.level
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to do this, the linter already handles the error level if there is an error thrown.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh it looks like you took this from prefer_english_operator yeah this probably isn't needed.

@swang
Copy link
Collaborator

swang commented Feb 19, 2016

Looks good, if you could delete line 16-18 in the rules, and just have it return { context }

Sorry for the delay.

@berrberr
Copy link
Author

Thanks for taking a look! Added those changes in.

@idoo
Copy link

idoo commented Jan 26, 2017

@clutchski bump 🔫

@clutchski
Copy link
Owner

clutchski commented Jan 26, 2017 via email

@UziTech
Copy link

UziTech commented Jan 14, 2020

Further development on coffeelint will be on coffeelint/coffeelint and will be released as @coffeelint/cli.

This PR will be tracked at coffeelint/coffeelint#13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants