Skip to content

Conversation

@DMwangnima
Copy link
Contributor

@DMwangnima DMwangnima commented Jan 2, 2026

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: 支持 ttstream 使用 protobuf 负载

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

  1. TTHeader Streaming 支持 protobuf
  2. 复用 gRPC protobuf Encode/Decode 逻辑

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners January 2, 2026 07:19
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 88.57143% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.57%. Comparing base (bfa27f3) to head (af4d3f1).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
pkg/remote/trans/ttstream/codec.go 87.50% 3 Missing and 3 partials ⚠️
pkg/remote/codec/grpc/grpc.go 61.53% 3 Missing and 2 partials ⚠️
pkg/remote/trans/ttstream/frame.go 70.00% 2 Missing and 1 partial ⚠️
internal/codec/protobuf_struct.go 97.14% 1 Missing and 1 partial ⚠️
pkg/remote/trans/ttstream/client_handler.go 83.33% 1 Missing and 1 partial ⚠️
pkg/remote/trans/ttstream/transport_client.go 50.00% 1 Missing ⚠️
pkg/remote/trans/ttstream/transport_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1906      +/-   ##
==========================================
+ Coverage   61.37%   61.57%   +0.19%     
==========================================
  Files         388      390       +2     
  Lines       35063    29981    -5082     
==========================================
- Hits        21521    18461    -3060     
+ Misses      12247    10232    -2015     
+ Partials     1295     1288       -7     
Flag Coverage Δ
integration 51.63% <60.57%> (+1.13%) ⬆️
unit 51.93% <69.71%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima force-pushed the feat/ttstream_pb branch 8 times, most recently from e2c3ce4 to 131b94b Compare January 5, 2026 03:19
{{template "@client.go-NewClient-option" .}}
{{if .HasStreaming}}
{{- if eq $.Codec "thrift"}}{{/* thrift streaming enable ttheader streaming protocol by default */}}
{{/* thrift streaming enable ttheader streaming protocol by default */}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无论是 protobuf 还是 thrift,默认使用 TTHeader Streaming

@DMwangnima DMwangnima force-pushed the feat/ttstream_pb branch 3 times, most recently from a0709ee to 26ba0b9 Compare January 6, 2026 02:25
@DMwangnima DMwangnima changed the title feat: support ttstream with protobuf payload [WIP] feat: support ttstream with protobuf payload Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant