Feature/234 add multifactor management#235
Open
l-friebe wants to merge 20 commits into
Open
Conversation
…ect elements based on value
…d since we can't edit those entries
…n / user ldap host and prt from doguctl if not supplied by env variables
notmyown
reviewed
Jun 26, 2026
| result.setUsername(username); | ||
| result.setName(name); | ||
| } | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
shouldn't use generic exceptions
| "users.mfa.device.name": "Gerätename", | ||
| "users.mfa.buttons.delete": "2. Faktor zurücksetzen", | ||
| "users.mfa.delete.confirmation.title": "Zweiten Faktor zurücksetzen", | ||
| "users.mfa.delete.confirmation.message": "Zweiten Faktor für {{username}} wirklich zurücksetzen? {{username}} muss beim nächsten Login einen neuen 2. Faktor einrichten.", |
Contributor
There was a problem hiding this comment.
unify quoting for username.
| "users.mfa.device.name": "Device name", | ||
| "users.mfa.buttons.delete": "Reset two-factor authentication", | ||
| "users.mfa.delete.confirmation.title": "Reset two-factor authentication", | ||
| "users.mfa.delete.confirmation.message": "Reset the two-factor authentication for {{username}}? {{username}} must configure the second factor on the next login.", |
| signal: signal | ||
| }); | ||
|
|
||
| if (response.status < 200 || response.status > 299) { |
Contributor
There was a problem hiding this comment.
usermgt allready imports lodash.
import { inRange } from 'lodash';
inRange(status, 200, 300) (excludes 300)
as this is used very often it could be a helper function
validStatus(status) {
return inRange(status, 200, 300)
}
| signal: signal, | ||
| } as any); | ||
|
|
||
| if (response.status < 200 || response.status > 299) { |
Contributor
There was a problem hiding this comment.
helper - see comment above
| {} | ||
| ); | ||
|
|
||
| if (response.status < 200 || response.status > 299) { |
Contributor
There was a problem hiding this comment.
helper - see comment above
| { | ||
| "Name": "official/usermgt", | ||
| "Version": "1.21.0-4", | ||
| "Version": "1.21.0-511", |
Contributor
There was a problem hiding this comment.
revert to -4 before release
| { | ||
| "Name": "experimental/totp/api_user_name", | ||
| "Description": "Warning: Experimental Feature. Username for totp administration. Supply the same username to the usermgt dogu.", | ||
| "Default": "admin123", |
| { | ||
| "Name": "experimental/totp/api_user_password", | ||
| "Description": "Warning: Experimental Feature. API password for totp administration. Supply the same password to the usermgt dogu.", | ||
| "Default": "password123", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.