Update docs to add disclaimer for quiche example binaries #2094
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrouviere
approved these changes
Jul 3, 2025
README.md
Outdated
| ⚠️ Disclaimers & Notes | ||
| --------- | ||
|
|
||
| * quiche-server is only a demo—for testing and examples. It is not production-ready and offers no performance, security or reliability guarantees. |
Contributor
There was a problem hiding this comment.
Suggested change
| * quiche-server is only a demo—for testing and examples. It is not production-ready and offers no performance, security or reliability guarantees. | |
| * quiche-server is only for testing and examples. It is not production-ready and offers no performance, security or reliability guarantees. |
Contributor
There was a problem hiding this comment.
Is there a benefit having this here and above?
README.md
Outdated
|
|
||
| * quiche-server is only a demo—for testing and examples. It is not production-ready and offers no performance, security or reliability guarantees. | ||
|
|
||
| * FFI/C examples and server tools are proof-of-concept, intended to guide usage rather than serve in production. |
Contributor
There was a problem hiding this comment.
Suggested change
| * FFI/C examples and server tools are proof-of-concept, intended to guide usage rather than serve in production. | |
| * FFI/C examples and server tools are proof-of-concept, intended to guide usage rather than serve production traffic |
evanrittenhouse
approved these changes
Jul 3, 2025
rushilmehra
approved these changes
Jul 3, 2025
Collaborator
Author
|
From @LPardue - We need to generalise the statement more - any binary we include in the quiche project has no performance, security or reliability guarantees. |
LPardue
force-pushed
the
nmicht/readme
branch
from
bab3407 to
fc8d69d
Compare
LPardue
force-pushed
the
nmicht/readme
branch
from
fc8d69d to
35ab83f
Compare
LPardue
changed the title
jrouviere
reviewed
Jan 13, 2026
jannes
approved these changes
Jan 13, 2026
Co-authored-by: Julien Rouviere <[email protected]>
cfjubacf
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have received security reports related to quiche demo applications. By design quiche-server and other quiche demo apps are not intended for to be used in production environments. Those offer no performance, security or reliability guarantees.
About this change
We want to update the README to be intentionally clear about this.