Skip to content

style: toc design improvements#29124

Merged
MohamedH1998 merged 8 commits intostyle/header-improvementsfrom
style/toc-improvements
Mar 20, 2026
Merged

style: toc design improvements#29124
MohamedH1998 merged 8 commits intostyle/header-improvementsfrom
style/toc-improvements

Conversation

@MohamedH1998
Copy link

@MohamedH1998 MohamedH1998 commented Mar 19, 2026

Summary

  • design improvements to the Table of Contents and the Feedback prompt

Screenshots (optional)

Before
Screenshot 2026-03-19 at 23 20 21

Screenshot 2026-03-19 at 23 20 28

After
Screenshot 2026-03-19 at 23 20 41

Screenshot 2026-03-19 at 23 21 22

Screen recording

Screen.Recording.2026-03-19.at.23.22.04.mov

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

@MohamedH1998 MohamedH1998 force-pushed the style/toc-improvements branch from 6b554e2 to 1f28a9d Compare March 19, 2026 13:36
@MohamedH1998 MohamedH1998 force-pushed the style/header-improvements branch from 43bdb92 to 282b4e6 Compare March 19, 2026 13:37
@MohamedH1998 MohamedH1998 marked this pull request as ready for review March 19, 2026 17:11
@MohamedH1998 MohamedH1998 requested review from a team and kodster28 as code owners March 19, 2026 17:11
@mvvmm
Copy link
Contributor

mvvmm commented Mar 19, 2026

/bonk please review

Copy link
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design improvements! The 'Table Track' design system with the vertical active indicator is a great UX enhancement.

One minor suggestion to consider:

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 19, 2026

Review posted successfully. The bash error was just a shell parsing issue but the API call succeeded.

Summary:

This PR delivers excellent design improvements to the Table of Contents:

Strengths:

  • Beautiful "Table Track" design system with the vertical active indicator
  • Significant accessibility improvements (fieldset/legend, sr-only text, focus-visible states)
  • Well-structured, maintainable CSS with clear documentation
  • Modernized feedback form UI with better UX
  • Proper use of CSS custom properties for theming

One suggestion: I noted that the data-tag-serp-link attribute was removed from tag links - this should be preserved if used for analytics/tracking.

Overall, this is a high-quality design improvement that enhances both aesthetics and accessibility.

github run

@MohamedH1998 MohamedH1998 merged commit f2f478c into style/header-improvements Mar 20, 2026
4 checks passed
@MohamedH1998 MohamedH1998 deleted the style/toc-improvements branch March 20, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants