feat(clap-complete): Introduce fallible generator #6009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtema
force-pushed
the
complete_try_generate
branch
from
4082068 to
c713eab
Compare
epage
reviewed
May 23, 2025
gtema
force-pushed
the
complete_try_generate
branch
2 times, most recently
from
25efcf8 to
7cc0aae
Compare
epage
reviewed
May 26, 2025
It may happen that writing completion fails due to whichever reason. Currently clap-complete panics without letting calling code to react on that error (i.e. ignore). Introduce fallible version of the `generate` function by mostly only getting rid of except and instead exposing Result. For backwards compatibility make default trait implementation of `try_generate` function to call `generate` not to break users defining their own `generate`. Issue: clap-rs#5993
gtema
force-pushed
the
complete_try_generate
branch
from
7cc0aae to
21fc9e4
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that writing completion fails due to whichever reason. Currently clap-complete panics without letting calling code to react on that error (i.e. ignore). Introduce fallible version of the
generatefunction by mostly only getting rid of except and instead exposing Result. For backwards compatibility make default trait implementation oftry_generatefunction to callgeneratenot to break users defining their owngenerate.Issue: #5993