Rename AppendNodeMutation and TrimNodeMutation to gene-level naming#782
Merged
Merged
Conversation
Struct, field, function, and test names updated for consistency (mutation extends a gene, not a single node).
Struct, field, function, and test names updated for consistency (mutation operates per gene, not per node).
chrxh
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppendNodeMutationtoExtendGeneMutationandTrimNodeMutationtoTrimGeneMutation, matching the gene-level mutation naming convention already used forDuplicateGeneMutation/DeleteGeneMutation(both mutations act per-gene, keyed bygeneProbability, not per-node).applyMutations_appendNode/applyMutations_trimNodekernel functions, the meta-mutation sigma parameters, GUI labels/settings keys, and test class/case names for both.trimNodes(...)helper inGenomeDescEditService.cpp(genome-preview cell-count trimming) untouched — different feature, coincidental name overlap.Test plan
external/vcpkgsubmodule not initialized in this environment)EngineInterfaceTests.exe,NetworkTests.exe,PersisterTests.exeEngineTests.exe --gtest_filter=ExtendGeneMutationTests.*:TrimGeneMutationTests.*:MetaMutationTests.*extendGene*:MetaMutationTests.*trimGene*:AccumulatedMutationTests*🤖 Generated with Claude Code