Fix nested route support for InboxLive #5
Merged
+124
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nested route support for InboxLive
Problem
When mounting the FYI routes in a nested scope (e.g.,
/admin/fyiinstead of/fyi), theInboxLive URLs were hardcoded to
/fyi/*, causing 404 errors when clicking on event details.Solution
handle_params/3build_url/3andevent_url/4to use the extracted route prefix instead ofhardcoded paths
event_url/4handle both socket and assigns parameters for template compatibilityTesting
test/fyi/web/inbox_live_test.exs) with 13 tests covering:Impact
Users can now mount FYI routes at any scope level:
/fyi(default)/admin/fyi/admin/dashboard/fyi