(#3817) Append download tab completion options #3818
Merged
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
3817-tab-completions
branch
from
8565b79 to
20804af
Compare
gep13
requested changes
Nov 21, 2025
Add comprehensive completion entries for the `choco download` command to TabExpansion and update tests to assert those completions when the licensed/pro features are available. - Extend commandOptions.download with many download-related flags: allow-empty-checksums, allow-empty-checksums-secure, ignore-checksum, ignore-dependencies-from-source, require-checksums, and other existing download switches. This ensures the tab completion engine exposes all pro and non-pro download options. - Add a Pester test case (Should list completions for downolad (Licensed)) that verifies the completion list includes the newly added download switches. The test is skipped when the license flag ($isLicensed) is not set, preserving existing test behavior. This change fixes missing completions for `choco download`, improving the shell UX for licensed users and keeping tests aligned with available pro flags.
AdmiringWorm
force-pushed
the
3817-tab-completions
branch
from
20804af to
a951970
Compare
corbob
approved these changes
Nov 21, 2025
gep13
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
choco downloadoptions: allow-empty-checksums, allow-empty-checksums-secure, ignore-checksum, ignore-dependencies-from-source, require-checksums, and other existing download switches.Motivation and Context
choco downloadto improve shell UX for licensed/pro users and ensure completion parity with available command flags.Testing
. .\src\chocolatey.resources\helpers\ChocolateyTabExpansion.ps1.choco downloadthe continue hitting thetabcharacter to verify the following options are showing up:--allow-empty-checksums--allow-empty-checksums-secure--ignore-checksum--ignore-dependencies-from-source=''--require-checksumsOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3817