rename M_HLVX to prevent clashing with M_FLUSH #3335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ZenithalHourlyRate
approved these changes
May 1, 2023
Contributor
ZenithalHourlyRate
left a comment
ZenithalHourlyRate
left a comment
There was a problem hiding this comment.
After inspecting M_HLVX related spec/code, it seems like a mistake instead of an intended clashing.
The order of the constants is also a hint.
Could you make this change against the dev branch? It will be backported to the master branch using mergify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
Renamed the constant M_HLVX from
10000to11000to prevent clashing with M_FLUSH, asisReadwould always return true for memory commands withM_FLUSH.Note: The bug was spotted while working with
boom/src/main/scala/lsu/dcache.scalaof the BOOM. This preventsM_FLUSHcommands from sending a response ass2_send_respwould always evaluate to false.