This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Feature/sass styles #358
Open
Feature/sass styles #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated all dev dependencies to current added jasmine-core to satisfy peer dependencies updated syntax in unit tests due to breaking changes in jasmine 2.x syntax
added grunt-sass to dev dependancies css refactored as sass sass task added to gruntfile and included as part of default
sass linter added to dev dependancies and to default task postCSS added to add vendor prefixes to css removed old css file pointed the example to the build folder's compiled css where it was referencing the old src css file
|
Tried it out and it looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@faceleg
I've refactored the existing css as SCSS, and added sass, post css for auto-prefixing, and linting tasks for these changes in the dev dependencies and build task.
This gives access to nice things like nested syntax, variables, functions, mixins etc. This makes it easier to maintain and allows users to customize the scss variables of the package.
This contains the same dev dependency updates as #357
please review