Settings: Add JSON template system and migration - refs #6427 #6448
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,807 @@ | |||
| <?php | |||
There was a problem hiding this comment.
File SettingsValueTemplateFixtures.php has 786 lines of code (exceeds 250 allowed). Consider refactoring.
| /** | ||
| * Returns the list of JSON templates grouped by category. | ||
| */ | ||
| public static function getTemplatesGrouped(): array |
There was a problem hiding this comment.
Method getTemplatesGrouped has 739 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
| } | ||
|
|
||
| public function down(Schema $schema): void |
There was a problem hiding this comment.
Method down has 28 lines of code (exceeds 25 allowed). Consider refactoring.
| return 'Adds value_template_id column to settings table and creates settings_value_template table for JSON templates.'; | ||
| } | ||
|
|
||
| public function up(Schema $schema): void |
There was a problem hiding this comment.
Function up has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
| } | ||
| } | ||
|
|
||
| public function down(Schema $schema): void |
There was a problem hiding this comment.
Function down has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 4b12728 and detected 12 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
2 participants
No description provided.