Plugin: Add config-based control for global conference roles visibility in BBB - refs #3498 #6336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 00569a0 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| break; | ||
| case STUDENT_BOSS: | ||
| if (api_is_student_boss()) { | ||
| return true; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| @@ -159,6 +159,42 @@ public static function updateCourseFieldInAllCourses(string $variable, string $v | |||
| $entityManager->flush(); | |||
| } | |||
|
|
|||
| public function canCurrentUserSeeGlobalConferenceLink(): bool | |||
There was a problem hiding this comment.
Method canCurrentUserSeeGlobalConferenceLink has 29 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -159,6 +159,42 @@ public static function updateCourseFieldInAllCourses(string $variable, string $v | |||
| $entityManager->flush(); | |||
| } | |||
|
|
|||
| public function canCurrentUserSeeGlobalConferenceLink(): bool | |||
There was a problem hiding this comment.
Function canCurrentUserSeeGlobalConferenceLink has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.