-
Notifications
You must be signed in to change notification settings - Fork 213
Add terminate selected tasks action in admin #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please elaborate the change a bit more? can you also verify the change?
When a long task is in running state, I may need to terminate it for various reasons. So adding this action in admin is useful. I added the code and tested it and it works fine. In the beginning I was terminating tasks one by one in a for loop, later I realized that I could pass in a list, so I made some changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add tests to verify this? and do not introduce any regression?
Okay, I'll try. |
@caoqianming unittests are run using install a virtualenv with the test dependencies, make sure you are on python 3.11:
This requires a postgres database to be available on Currently there are no tests testing the admin pages since there was very little functionality there, so you'll have to add a test_admin.py yourself. |
Hello. I add some test @AllexVeldman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new action to the Django admin interface allowing administrators to terminate selected tasks, along with corresponding unit tests.
- Introduces terminate_task action in TaskResultAdmin which terminates tasks and reports success or error messages.
- Adds unit tests in t/unit/test_admin.py covering both successful termination and failure scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
t/unit/test_admin.py | Adds tests for the new terminate_task action |
django_celery_results/admin.py | Implements the terminate_task action in the admin |
Comments suppressed due to low confidence (1)
t/unit/test_admin.py:27
- [nitpick] The variable name 'id' shadows the built-in function id(). Consider renaming it to 'task_id' or similar to avoid potential confusion.
id = uuid()
my concern is while this intorduce any unintended stuff? or it too risky? |
No description provided.