Skip to content

Static tests #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 16, 2025
Merged

Static tests #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
967c9b5
Some static tests added
yzh-pelle Apr 11, 2025
da1c056
some fixes for php-binance-api.php
yzh-pelle Apr 13, 2025
edbe3c1
tests for spot added
yzh-pelle Apr 13, 2025
69a2dd5
futuresPremiumIndexKlines renamed to futuresPremiumIndexCandlesticks
yzh-pelle Apr 13, 2025
4ea3b93
symbolPeriodLimitStartEndRequest method name updated
yzh-pelle Apr 13, 2025
a024d7d
Editing futures orders updated
yzh-pelle Apr 13, 2025
aa0f51e
futuresCancelBatchOrders updated
yzh-pelle Apr 13, 2025
71cadd8
some futures tests added
yzh-pelle Apr 13, 2025
30bf029
Futures tests added
yzh-pelle Apr 14, 2025
e7b2341
Query check is updated
yzh-pelle Apr 14, 2025
42811fe
typo fixed
yzh-pelle Apr 14, 2025
44ff64e
another typo fixed
yzh-pelle Apr 14, 2025
726e266
a few `print_r` removed
yzh-pelle Apr 14, 2025
02b7d72
A few warnings for empty response added
yzh-pelle Apr 14, 2025
d46a82d
Some other checks for empty response added
yzh-pelle Apr 14, 2025
a8b7a22
Another check for empty response added
yzh-pelle Apr 14, 2025
25775ae
most of warnings in tests are handled
yzh-pelle Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 92 additions & 41 deletions php-binance-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,9 +692,6 @@ public function exchangeInfo($symbols = null)
{
if (!$this->exchangeInfo) {
$arr = array();
$arr['symbols'] = array();
$parameters = [];

if ($symbols) {
if (gettype($symbols) == "string") {
$parameters["symbol"] = $symbols;
Expand All @@ -706,7 +703,11 @@ public function exchangeInfo($symbols = null)
} else {
$arr = $this->httpRequest("v3/exchangeInfo");
}

if ((is_array($arr) === false) || empty($arr)) {
echo "Error: unable to fetch spot exchange info" . PHP_EOL;
$arr = array();
$arr['symbols'] = array();
}
$this->exchangeInfo = $arr;
$this->exchangeInfo['symbols'] = null;

Expand Down Expand Up @@ -921,13 +922,16 @@ public function depositAddress(string $asset, $network = null)
$return = $this->httpRequest("v1/capital/deposit/address", "GET", $params, true);

// Adding for backwards compatibility with wapi
$return['asset'] = $return['coin'];
$return['addressTag'] = $return['tag'];

if (!empty($return['address'])) {
$return['success'] = 1;
if (is_array($return) && !empty($return)) {
$return['asset'] = $return['coin'];
$return['addressTag'] = $return['tag'];
if (!empty($return['address'])) {
$return['success'] = 1;
} else {
$return['success'] = 0;
}
} else {
$return['success'] = 0;
echo "Error: no deposit address found" . PHP_EOL;
}

return $return;
Expand Down Expand Up @@ -955,8 +959,12 @@ public function depositHistory(string $asset = null, array $params = [])
$return = $this->httpRequest("v1/capital/deposit/hisrec", "GET", $params, true);

// Adding for backwards compatibility with wapi
foreach ($return as $key=>$item) {
$return[$key]['asset'] = $item['coin'];
if (is_array($return) && !empty($return)) {
foreach ($return as $key=>$item) {
$return[$key]['asset'] = $item['coin'];
}
} else {
echo "Error: no deposit history found" . PHP_EOL;
}

return $return;
Expand Down Expand Up @@ -1091,7 +1099,7 @@ public function transfer(string $type, string $asset, string $amount, $fromSymbo
*
* @property int $weight 1
*
* @param string $type (optional) type of transfer, e.g. MAIN_MARGIN (@see transfer())
* @param string $type (mandatory) type of transfer, e.g. MAIN_MARGIN (@see transfer())
* @param string $startTime (optional) start time in milliseconds
* @param string $endTime (optional) end time in milliseconds
* @param int $limit (optional) the number of records to return (default 10, max 100)
Expand Down Expand Up @@ -1158,7 +1166,10 @@ public function prices()
public function price(string $symbol)
{
$ticker = $this->httpRequest("v3/ticker/price", "GET", ["symbol" => $symbol]);

if (!isset($ticker['price'])) {
echo "Error: unable to fetch price for $symbol" . PHP_EOL;
return null;
}
return $ticker['price'];
}

Expand Down Expand Up @@ -1283,6 +1294,14 @@ public function depth(string $symbol, int $limit = 100)
"symbol" => $symbol,
"limit" => $limit,
]);
if (is_array($json) === false) {
echo "Error: unable to fetch depth" . PHP_EOL;
$json = [];
}
if (empty($json)) {
echo "Error: depth were empty" . PHP_EOL;
return $json;
}
if (isset($this->info[$symbol]) === false) {
$this->info[$symbol] = [];
}
Expand Down Expand Up @@ -3112,7 +3131,7 @@ public function accountSnapshot($type, $nbrDays = 5, $startTime = 0, $endTime =
if ($startTime > 0)
$params['startTime'] = $startTime;
if ($endTime > 0)
$params['endTime'] = $startTime;
$params['endTime'] = $endTime;
if ($nbrDays != 5)
$params['limit'] = $nbrDays;

Expand Down Expand Up @@ -3249,6 +3268,14 @@ public function ocoOrder(string $side, string $symbol, $quantity, $price, $stopp
public function avgPrice(string $symbol)
{
$ticker = $this->httpRequest("v3/avgPrice", "GET", ["symbol" => $symbol]);
if (is_array($ticker) === false) {
echo "Error: unable to fetch avg price" . PHP_EOL;
$ticker = [];
}
if (empty($ticker)) {
echo "Error: avg price was empty" . PHP_EOL;
return null;
}
return $ticker['price'];
}

Expand Down Expand Up @@ -3320,11 +3347,12 @@ public function futuresTime()
public function futuresExchangeInfo()
{
if (!$this->futuresExchangeInfo) {
$arr = array();
$arr['symbols'] = array();

$arr = $this->httpRequest("v1/exchangeInfo", "GET", [ 'fapi' => true ]);

if ((is_array($arr) === false) || empty($arr)) {
echo "Error: unable to fetch futures exchange info" . PHP_EOL;
$arr = array();
$arr['symbols'] = array();
}
$this->futuresExchangeInfo = $arr;
$this->futuresExchangeInfo['symbols'] = null;

Expand Down Expand Up @@ -3369,6 +3397,14 @@ public function futuresDepth(string $symbol, int $limit = null)
$params['limit'] = $limit;
}
$json = $this->httpRequest("v1/depth", "GET", $params);
if (is_array($json) === false) {
echo "Error: unable to fetch futures depth" . PHP_EOL;
$json = [];
}
if (empty($json)) {
echo "Error: futures depth were empty" . PHP_EOL;
return $json;
}
if (isset($this->info[$symbol]) === false) {
$this->info[$symbol] = [];
$this->info[$symbol]['futures'] = [];
Expand Down Expand Up @@ -3588,12 +3624,12 @@ public function futuresMarkPriceCandlesticks(string $symbol, string $interval =
}

/**
* futuresPremiumIndexKlines get the candles for the given intervals
* futuresPremiumIndexCandlesticks get the candles for the given intervals
* 1m,3m,5m,15m,30m,1h,2h,4h,6h,8h,12h,1d,3d,1w,1M
*
* @link https://developers.binance.com/docs/derivatives/usds-margined-futures/market-data/rest-api/Premium-Index-Kline-Data
*
* $candles = $api->futuresPremiumIndexKlines("ETHBTC", "5m");
* $candles = $api->futuresPremiumIndexCandlesticks("ETHBTC", "5m");
*
* @property int $weight 5
* for limit < 100 - weight 1
Expand All @@ -3610,7 +3646,7 @@ public function futuresMarkPriceCandlesticks(string $symbol, string $interval =
* @return array containing the response
* @throws \Exception
*/
public function futuresPremiumIndexKlines(string $symbol, string $interval = '5m', int $limit = null, $startTime = null, $endTime = null)
public function futuresPremiumIndexCandlesticks(string $symbol, string $interval = '5m', int $limit = null, $startTime = null, $endTime = null)
{
return $this->futuresCandlesticksHelper($symbol, $interval, $limit, $startTime, $endTime, 'premiumIndexKlines');
}
Expand All @@ -3627,11 +3663,11 @@ private function futuresCandlesticksHelper($symbol, $interval, $limit, $startTim
if (!isset($this->charts['futures'][$symbol])) {
$this->charts['futures'][$symbol] = [];
}
if (!isset($this->charts['futures'][$symbol][$type])) {
$this->charts['futures'][$symbol][$type] = [];
if (!isset($this->charts['futures'][$symbol][$contractType])) {
$this->charts['futures'][$symbol][$contractType] = [];
}
if (!isset($this->charts['futures'][$symbol][$type][$interval])) {
$this->charts['futures'][$symbol][$type][$interval] = [];
if (!isset($this->charts['futures'][$symbol][$contractType][$interval])) {
$this->charts['futures'][$symbol][$contractType][$interval] = [];
}
$params = [
'interval' => $interval,
Expand Down Expand Up @@ -3800,6 +3836,10 @@ public function futuresPrice(string $symbol)
'fapi' => true,
];
$ticker = $this->httpRequest("v1/ticker/price", "GET", $parameters);
if (!isset($ticker['price'])) {
echo "Error: unable to fetch futures price for $symbol" . PHP_EOL;
return null;
}
return $ticker['price'];
}

Expand Down Expand Up @@ -3844,6 +3884,10 @@ public function futuresPriceV2(string $symbol)
'fapi' => true,
];
$ticker = $this->httpRequest("v2/ticker/price", "GET", $parameters);
if (!isset($ticker['price'])) {
echo "Error: unable to fetch futures price for $symbol" . PHP_EOL;
return null;
}
return $ticker['price'];
}

Expand Down Expand Up @@ -3943,7 +3987,7 @@ public function futuresOpenInterest(string $symbol): array
* symbolPeriodLimitStartEndRequest
* helper for routing GET methods that require symbol, period, limit, startTime and endTime
*/
private function symbolPeriodLimitStartEndContractTypeRequest($symbol, $period, $limit, $startTime, $endTime, $url, $base = 'fapi', $contractType = null)
private function symbolPeriodLimitStartEndRequest($symbol, $period, $limit, $startTime, $endTime, $url, $base = 'fapi', $contractType = null)
{
$parameters = [
'symbol' => $symbol,
Expand Down Expand Up @@ -4477,7 +4521,7 @@ public function futuresSellTest(string $symbol, $quantity = null, $price = null,
* @return array containing the request
* @throws \Exception
*/
protected function createBatchOrdersRequest(array $orders)
protected function createBatchOrdersRequest(array $orders, bool $edit = false)
{
$formatedOrders = [];
for ($index = 0; $index < count($orders); $index++) {
Expand All @@ -4491,6 +4535,9 @@ protected function createBatchOrdersRequest(array $orders)
if (!isset($order['flags'])) {
$order['flags'] = [];
}
if (!isset($order['type'])) {
$order['type'] = 'LIMIT';
}
$formatedOrder = $this->createFuturesOrderRequest(
$order['side'],
$order['symbol'],
Expand All @@ -4503,11 +4550,15 @@ protected function createBatchOrdersRequest(array $orders)
// remove recvWindow from the order
unset($formatedOrder['recvWindow']);
}
if (isset($order['orderId'])) {
$formatedOrder['orderId'] = $order['orderId'];
}
if (isset($order['origClientOrderId'])) {
$formatedOrder['origClientOrderId'] = $order['origClientOrderId'];
if ($edit) {
if (isset($order['orderId'])) {
$formatedOrder['orderId'] = $order['orderId'];
}
if (isset($order['origClientOrderId'])) {
$formatedOrder['origClientOrderId'] = $order['origClientOrderId'];
}
unset($formatedOrder['type']);
unset($formatedOrder['newClientOrderId']);
}
$formatedOrders[$index] = $formatedOrder;
}
Expand Down Expand Up @@ -4580,6 +4631,7 @@ public function futuresEditOrder(string $symbol, string $side, string $quantity,
$opt['orderId'] = $orderId;
}
unset($opt['type']);
unset($opt['newClientOrderId']);
$opt['fapi'] = true;
return $this->httpRequest("v1/order", 'PUT', $opt, true);
}
Expand All @@ -4601,14 +4653,13 @@ public function futuresEditOrders(array $orders, $recvWindow = null)
$params = [
'fapi' => true,
];
$formatedOrders = $this->createBatchOrdersRequest($orders);
$formatedOrders = $this->createBatchOrdersRequest($orders, true);
if ($recvWindow) {
$params['recvWindow'] = $recvWindow;
}
// current endpoint accepts orders list as a json string in the query string
$encodedOrders = json_encode($formatedOrders);
$url = 'v1/batchOrders?batchOrders=' . $encodedOrders;
return $this->httpRequest($url, 'PUT', $params, true);
$params['batchOrders'] = json_encode($formatedOrders);
return $this->httpRequest("v1/batchOrders", 'PUT', $params, true);
}

/**
Expand Down Expand Up @@ -4710,8 +4761,8 @@ public function futuresCancelBatchOrders(string $symbol, $orderIdList = null, $o
// remove quotes and spaces
$params['orderIdList'] = str_replace(' ', '', str_replace('"', '', str_replace("'", '', $idsString)));
} else if ($origClientOrderIdList) {
// remove spaces
$params['origClientOrderIdList'] = str_replace(' ', '', json_encode($origClientOrderIdList));
// remove spaces between the ids
$params['origClientOrderIdList'] = str_replace(', ', ',', json_encode($origClientOrderIdList));
} else {
throw new \Exception('futuresCancelBatchOrders: either orderIdList or origClientOrderIdList must be set');
}
Expand Down Expand Up @@ -6054,7 +6105,7 @@ public function convertAccept(string $quoteId, int $recvWindow = null, array $pa
$request = [
'quoteId' => $quoteId,
];
return $this->fapiRequest("v1/cconvert/acceptQuote", 'POST', array_merge($request, $params), true, $recvWindow);
return $this->fapiRequest("v1/convert/acceptQuote", 'POST', array_merge($request, $params), true, $recvWindow);
}

/**
Expand Down Expand Up @@ -6098,4 +6149,4 @@ public function convertStatus($orderId = null, $quoteId = null)
}
return $this->httpRequest("v1/convert/orderStatus", 'GET', $params, true);
}
}
}
Loading