Skip to content

Add -Wsign-conversion to the list of common warning flags #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from
Open

Add -Wsign-conversion to the list of common warning flags #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd34415
Fixed sign conversion warnings in catch_reporter_console
Wmbat Dec 6, 2023
ff8d5dc
Fixed sign conversion warnings in catch_reporter_multi
Wmbat Dec 6, 2023
d922c24
Fixed sign conversion warnings in catch_timer
Wmbat Dec 6, 2023
1f2d645
Fixed sign conversion warnings in catch_test_case_info_hasher
Wmbat Dec 6, 2023
aea6ef0
Fixed sign conversion warnings in Evt-EventListeners
Wmbat Dec 6, 2023
90f6fcf
Fixed sign conversion warnings in Generators.tests
Wmbat Dec 6, 2023
eb8ecf8
Fixed sign conversion warnings in Sharding.tests
Wmbat Dec 6, 2023
8d0f12f
Fixed sign conversion warnings in Benchmark.tests
Wmbat Dec 6, 2023
6eaa74b
Fixed Generators.Tests warnings
Wmbat Dec 6, 2023
01c021d
Fixing sign conversion warnings in MatchersRanges.tests
Wmbat Dec 6, 2023
1d322a4
Moved -Wsign-conversion flag to the correct alphabetical position
Wmbat Dec 6, 2023
51f021d
Switch to using iterator instead of index for TablePrinter
Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMake/CatchMiscFunctions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ function(add_warnings_to_targets targets)
"-Wreorder"
"-Wreturn-std-move"
"-Wshadow"
"-Wsign-conversion"
"-Wstrict-aliasing"
"-Wsubobject-linkage"
"-Wsuggest-destructor-override"
Expand Down
Binary file added build/.ninja_deps
View file
Open in desktop
Binary file not shown.
109 changes: 109 additions & 0 deletions build/.ninja_log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
# ninja log v6
3 75 1743283889781224506 src/CMakeFiles/Catch2.dir/catch2/generators/catch_generator_exception.cpp.o 76248fb3abdd685e
636 1384 1743283890413187578 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_sonarqube.cpp.o c3d6df068850d4d9
4 710 1743283889781837042 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_automake.cpp.o 863cfb87afe7058f
75 1224 1743283889852614553 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_helpers.cpp.o 60a71cd288c64488
10 614 1743283889787149169 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_event_listener.cpp.o f4d1f859cd984be7
4 814 1743283889782198132 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_compact.cpp.o 33c9f895625eb336
4 755 1743283889781413822 src/CMakeFiles/Catch2.dir/catch2/generators/catch_generators.cpp.o 660a36bff00ed80
615 972 1743283890392186289 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_registrars.cpp.o a5ae59cbb043dcf6
755 1378 1743283890532194878 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_tap.cpp.o e3be0860428ef32a
3 142 1743283889780763412 src/CMakeFiles/Catch2.dir/catch2/benchmark/detail/catch_benchmark_function.cpp.o d842edf9fe5d5db7
2 119 1743283889779148678 src/CMakeFiles/Catch2.dir/catch2/benchmark/catch_chronometer.cpp.o edfe9cbd4eca0e54
7 1112 1743283889784438783 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_cumulative_base.cpp.o d5878275e8a15b75
711 1167 1743283890488192179 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_streaming_base.cpp.o 4186a024a75ec78b
121 1257 1743283889898155980 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_json.cpp.o 46811bdc2e72f705
3 508 1743283889780916549 src/CMakeFiles/Catch2.dir/catch2/benchmark/detail/catch_run_for_at_least.cpp.o 6e26c2e74f80f962
3 636 1743283889780148740 src/CMakeFiles/Catch2.dir/catch2/benchmark/detail/catch_analyse.cpp.o 7cca7081689cff95
3 898 1743283889781050889 src/CMakeFiles/Catch2.dir/catch2/benchmark/detail/catch_stats.cpp.o a039e55c4fa39b74
142 1131 1743283889919157268 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_junit.cpp.o 2ea865a63c72936e
509 1257 1743283890286179786 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_multi.cpp.o 19549c16cad16d21
4 883 1743283889781574604 src/CMakeFiles/Catch2.dir/catch2/generators/catch_generators_random.cpp.o d656df7882d62099
4 855 1743283889782033353 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_common_base.cpp.o 5542fe7b80330266
5 197 1743284133358442405 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_testcase.cpp.o 83190cb0cd9f60ee
4 337 1743284133357684968 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_generatortracker.cpp.o 20f33863595db17b
4 344 1743284133357848855 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_registry_hub.cpp.o 26874adf9813ef2
4 369 1743284133357515600 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_exception.cpp.o cc69e7940e5ec007
3 386 1743284133357112539 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_capture.cpp.o 72d8829abada4188
3 432 1743284133357323998 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_config.cpp.o 2198e54a4e17b6bd
4 437 1743284133358227038 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_reporter_factory.cpp.o f09c69dbdab968d6
5 584 1743284133358911314 src/CMakeFiles/Catch2.dir/catch2/catch_assertion_result.cpp.o 76e32aa747f05d9c
4 758 1743284133358052670 src/CMakeFiles/Catch2.dir/catch2/interfaces/catch_interfaces_reporter.cpp.o e7c00ecaad7f370b
390 779 1743284133743156700 src/CMakeFiles/Catch2.dir/catch2/catch_tag_alias_autoregistrar.cpp.o d86daa54d2702ad2
584 843 1743284133937168646 src/CMakeFiles/Catch2.dir/catch2/catch_timer.cpp.o 34efec4ba347b6a7
197 852 1743284133550144816 src/CMakeFiles/Catch2.dir/catch2/catch_get_random_seed.cpp.o d48cfdb4ba2a72f
5 861 1743284133358665818 src/CMakeFiles/Catch2.dir/catch2/catch_approx.cpp.o 277651f1391fb0fa
779 869 1743284134132180653 src/CMakeFiles/Catch2.dir/catch2/catch_totals.cpp.o 16daeb4ae2dc0bbd
3 985 1743284133356763352 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_teamcity.cpp.o 73e3e382149b47bf
3 1051 1743284133356959923 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_xml.cpp.o 5b3e840ce1fc82fb
3 1064 1743284133356132870 src/CMakeFiles/Catch2.dir/catch2/reporters/catch_reporter_console.cpp.o b6f6b4f35991ec13
337 1159 1743284133690153436 src/CMakeFiles/Catch2.dir/catch2/catch_message.cpp.o e992a94aabb6f6e0
852 1239 1743284134205185148 src/CMakeFiles/Catch2.dir/catch2/catch_version.cpp.o 6b6421223486f2fd
1159 1242 1743284134512204052 src/CMakeFiles/Catch2.dir/catch2/internal/catch_context.cpp.o ea79d29629b00128
843 1249 1743284134196191230 src/CMakeFiles/Catch2.dir/catch2/catch_translate_exception.cpp.o beba88068bcf2b1f
10 1293 1743284133363133301 src/CMakeFiles/Catch2.dir/catch2/catch_config.cpp.o f466e68b1932d21a
433 1295 1743284133786159348 src/CMakeFiles/Catch2.dir/catch2/catch_test_case_info.cpp.o 241528837ef62443
344 1349 1743284133697153868 src/CMakeFiles/Catch2.dir/catch2/catch_registry_hub.cpp.o 4a0f26f16ab85f36
1349 1391 1743284134702215751 src/CMakeFiles/Catch2.dir/catch2/internal/catch_errno_guard.cpp.o 5c5767ed7e896a9b
437 1422 1743284133790159594 src/CMakeFiles/Catch2.dir/catch2/catch_test_spec.cpp.o bc8884f104464cca
869 1428 1743284134222186195 src/CMakeFiles/Catch2.dir/catch2/internal/catch_case_insensitive_comparisons.cpp.o ca12db0c227a0de7
861 1435 1743284134214185702 src/CMakeFiles/Catch2.dir/catch2/internal/catch_assertion_handler.cpp.o 34ad00dc24ac5818
1435 1530 1743284134788221047 src/CMakeFiles/Catch2.dir/catch2/internal/catch_getenv.cpp.o b3a3594c789dc29c
1239 1635 1743284134592208978 src/CMakeFiles/Catch2.dir/catch2/internal/catch_debug_console.cpp.o 34328f1ba4235643
758 1636 1743284134111179360 src/CMakeFiles/Catch2.dir/catch2/catch_tostring.cpp.o 55c6697446bd126d
1428 1749 1743284134781942954 src/CMakeFiles/Catch2.dir/catch2/internal/catch_floating_point_helpers.cpp.o 98732203e2ace38a
1064 1783 1743284134418198264 src/CMakeFiles/Catch2.dir/catch2/internal/catch_console_colour.cpp.o 86103994fb7954a
1293 1837 1743284134646212303 src/CMakeFiles/Catch2.dir/catch2/internal/catch_enforce.cpp.o c4f394dd082be635
1242 1842 1743284134596209224 src/CMakeFiles/Catch2.dir/catch2/internal/catch_debugger.cpp.o d70a1044dc5a5ae1
1249 1934 1743284134602209593 src/CMakeFiles/Catch2.dir/catch2/internal/catch_decomposer.cpp.o 653917630f4a91d0
1391 1953 1743284134744218337 src/CMakeFiles/Catch2.dir/catch2/internal/catch_exception_translator_registry.cpp.o b9b81e9dd4e79985
1295 2020 1743284134648212426 src/CMakeFiles/Catch2.dir/catch2/internal/catch_enum_values_registry.cpp.o faaed2cdb0bce471
1422 2055 1743284134775220246 src/CMakeFiles/Catch2.dir/catch2/internal/catch_fatal_condition_handler.cpp.o 983358795ea4a018
2020 2062 1743284135374257130 src/CMakeFiles/Catch2.dir/catch2/internal/catch_random_number_generator.cpp.o bb548d4af0f65b
1749 2150 1743284135102240381 src/CMakeFiles/Catch2.dir/catch2/internal/catch_leak_detector.cpp.o c6d003ad6cc00472
1530 2200 1743284134883226896 src/CMakeFiles/Catch2.dir/catch2/internal/catch_istream.cpp.o 638dd5998dcc89cf
1837 2239 1743284135190245800 src/CMakeFiles/Catch2.dir/catch2/internal/catch_message_info.cpp.o 133ec575b049054e
1636 2241 1743284134989233423 src/CMakeFiles/Catch2.dir/catch2/internal/catch_lazy_expr.cpp.o 1a25d033705fd7b2
1635 2272 1743284134988233362 src/CMakeFiles/Catch2.dir/catch2/internal/catch_jsonwriter.cpp.o 48259a4b444a7833
1934 2360 1743284135287251773 src/CMakeFiles/Catch2.dir/catch2/internal/catch_parse_numbers.cpp.o 17bf19bf33229b29
1953 2362 1743284135306252943 src/CMakeFiles/Catch2.dir/catch2/internal/catch_polyfills.cpp.o 3b530fe135b6ea9
1845 2457 1743284135198246292 src/CMakeFiles/Catch2.dir/catch2/internal/catch_output_redirect.cpp.o 8544706f27e704e5
2272 2529 1743284135626272647 src/CMakeFiles/Catch2.dir/catch2/internal/catch_singletons.cpp.o ea39e182a2ce2b22
2363 2626 1743284135716278189 src/CMakeFiles/Catch2.dir/catch2/internal/catch_startup_exception_registry.cpp.o 7c60a2d24d5755eb
985 2744 1743284134338193338 src/CMakeFiles/Catch2.dir/catch2/internal/catch_clara.cpp.o c830f6e8332cf5b5
369 2751 1743284133722155407 src/CMakeFiles/Catch2.dir/catch2/catch_session.cpp.o 981c1c9019512985
2362 2819 1743284135715278127 src/CMakeFiles/Catch2.dir/catch2/internal/catch_source_line_info.cpp.o fd60dd1f93296041
2241 2852 1743284135594270677 src/CMakeFiles/Catch2.dir/catch2/internal/catch_section.cpp.o c96aa42b2e86cb28
2055 2881 1743284135410259347 src/CMakeFiles/Catch2.dir/catch2/internal/catch_random_seed_generation.cpp.o c7dec0b33cb1f117
2200 2908 1743284135553268152 src/CMakeFiles/Catch2.dir/catch2/internal/catch_reusable_string_stream.cpp.o 9c6d117baf0d4f2c
1783 2941 1743284135136242475 src/CMakeFiles/Catch2.dir/catch2/internal/catch_list.cpp.o fb493b739bf93f15
2457 3003 1743284135810283977 src/CMakeFiles/Catch2.dir/catch2/internal/catch_stdstreams.cpp.o e68b40f887b3daa8
2150 3043 1743284135503265073 src/CMakeFiles/Catch2.dir/catch2/internal/catch_reporter_spec_parser.cpp.o 55ea28219b89b42
3043 3132 1743284136396320060 src/CMakeFiles/Catch2.dir/catch2/internal/catch_uncaught_exceptions.cpp.o 17951d63e4985bf9
2751 3160 1743284136104302080 src/CMakeFiles/Catch2.dir/catch2/internal/catch_test_case_info_hasher.cpp.o cb7137b188fd36cf
2529 3199 1743284135882288410 src/CMakeFiles/Catch2.dir/catch2/internal/catch_string_manip.cpp.o ef41f9bb308989b7
2626 3217 1743284135979294383 src/CMakeFiles/Catch2.dir/catch2/internal/catch_stringref.cpp.o 9a3e2804e7a45741
2062 3341 1743284135415259654 src/CMakeFiles/Catch2.dir/catch2/internal/catch_reporter_registry.cpp.o 73cb5e11857a98ff
2881 3386 1743284136234310085 src/CMakeFiles/Catch2.dir/catch2/internal/catch_test_failure_exception.cpp.o f75a60fdbc5ad721
2239 3456 1743284135593270615 src/CMakeFiles/Catch2.dir/catch2/internal/catch_run_context.cpp.o 28d34222e592e9d
2744 3472 1743284136098301711 src/CMakeFiles/Catch2.dir/catch2/internal/catch_tag_alias_registry.cpp.o 3db6b5f9520265b8
2941 3595 1743284136294313779 src/CMakeFiles/Catch2.dir/catch2/internal/catch_test_spec_parser.cpp.o 58d600f65789cf25
2909 3631 1743284136262311809 src/CMakeFiles/Catch2.dir/catch2/internal/catch_test_registry.cpp.o b6d603ebcdb6d964
1051 3638 1743284134404197402 src/CMakeFiles/Catch2.dir/catch2/internal/catch_commandline.cpp.o fb04b99bb042150f
2853 3702 1743284136206308361 src/CMakeFiles/Catch2.dir/catch2/internal/catch_test_case_tracker.cpp.o 786162cb2d1ddccc
3199 3804 1743284136552329666 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers.cpp.o b9a53017c7ae248b
3134 3839 1743284136487325663 src/CMakeFiles/Catch2.dir/catch2/internal/catch_wildcard_pattern.cpp.o e7ed1cbb23f7a1b1
3217 3847 1743284136570330774 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_container_properties.cpp.o 2ac42719f89e9c9
3004 3887 1743284136357317659 src/CMakeFiles/Catch2.dir/catch2/internal/catch_textflow.cpp.o 1274edfdf5d27e69
3342 3950 1743284136695338471 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_exception.cpp.o fd182986e2c7cfee
3160 3965 1743284136513327265 src/CMakeFiles/Catch2.dir/catch2/internal/catch_xmlwriter.cpp.o fd941bafd706dbe9
3457 3999 1743284136810345553 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_predicate.cpp.o a91d46642c28e150
3473 4057 1743284136826346538 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_quantifiers.cpp.o 929255c0ecf0615b
2820 4099 1743284136173306329 src/CMakeFiles/Catch2.dir/catch2/internal/catch_test_case_registry_impl.cpp.o 76ea17dae79f67ce
3386 4162 1743284136739341181 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_floating_point.cpp.o f1fd71501255d15d
3638 4176 1743284136992356759 src/CMakeFiles/Catch2.dir/catch2/matchers/internal/catch_matchers_impl.cpp.o 44ef1a782c28ff2f
3632 4194 1743284136985356328 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_templated.cpp.o 9c56e9c16e671ab1
3702 4308 1743284137055360639 src/CMakeFiles/Catch2WithMain.dir/catch2/internal/catch_main.cpp.o 2b088044e8d8274
3597 5607 1743284136950354173 src/CMakeFiles/Catch2.dir/catch2/matchers/catch_matchers_string.cpp.o 5c5b8c58aeee5d03
5607 5903 1743284138959477879 src/libCatch2d.a 6fc93669810a0a97
5903 5935 1743284139255496105 src/libCatch2Maind.a a75745778fb6f9f3
Loading