fix: icon & shape indicator overflow#21703
Closed
timfuhrmann wants to merge 2 commits intocarbon-design-system:mainfrom
Closed
fix: icon & shape indicator overflow#21703timfuhrmann wants to merge 2 commits intocarbon-design-system:mainfrom
timfuhrmann wants to merge 2 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21703 +/- ##
==========================================
- Coverage 87.70% 87.59% -0.12%
==========================================
Files 538 184 -354
Lines 43680 28694 -14986
Branches 6699 1766 -4933
==========================================
- Hits 38311 25135 -13176
+ Misses 5217 3533 -1684
+ Partials 152 26 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
reviewed
Mar 5, 2026
Contributor
maradwan26
left a comment
maradwan26
left a comment
There was a problem hiding this comment.
Hello the CI is failing. Looks like tests need to be updated to cover this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21700
In case you want to go through with a fix for the issue above. - This prevents both labels from overflowing but to properly truncate with an ellipsis.
Note: Previously multi word labels did wrap, now they won't anymore. In case this is not expected, I suggest to remove the CSS to prevent overflow again, but keep the span and class name for users to be able to apply it themselves, if necessary. Currently the label is not accessible via CSS.
Changelog
Changed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide