feat(tabs): create vertical tabs story#21654
feat(tabs): create vertical tabs story#21654sangeethababu9223 wants to merge 44 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21654 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 538 538
Lines 44982 44982
Branches 6459 6516 +57
=======================================
+ Hits 42739 42740 +1
+ Misses 2114 2113 -1
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5d6a863 to
b4d0066
Compare
…babu9223/carbon into feat/tabs-vertical-tab
…babu9223/carbon into feat/tabs-vertical-tab
There was a problem hiding this comment.
Great work @sangeethababu9223! Just some comments around buttons specs and props:
- Would we need the "contained" and "disabled" prop? It's not in the react storybook.
- When switched to a small size, the vertical tabs becomes the container tab the size and the color of the tab button is incorrect, sharing the specs below. Is this the part that you mentioned in your PR description under Note to create a separate issue for it?
- In react storybook, there is a prop called 'defaultSelectedIndex', which seems to be missing in WC storybook, is it intentional? (sharing the screenshot reference below)
- The props names in react and WC storybook are different like "height" in react and "customHeight" in WC, is it intentional?
- There is also a missing prop called 'selectedIndex' which is present in react and not in WC storybook, is that also intentional? I saw that you added a 'selectionMode' prop is that for this usecase?
Hey @Kritvi-bhatia17, Thank you for the detailed review! Let me address each point:
Once all Tab stories are complete, we can do a full comparison and update controls to ensure parity between React and Web Components where appropriate. We can track that here: #20954 |
Kritvi-bhatia17
left a comment
There was a problem hiding this comment.
LGTM @sangeethababu9223, thanks for answering all queries in depth! 🚀
…babu9223/carbon into feat/tabs-vertical-tab
Closes #19761
Adds vertical tabs support to Carbon Web Components, achieving parity with the React implementation.
Changelog
New
cds-tabs-vertical- Wrapper component for vertical tab layoutcustom-heightproperty for manual height controlTesting / Reviewing
In Web Components storybook, Vertical story should be there under Tabs component and the behaviour matches the react version.
Note:
In smaller screens Vertical tabs is expected to match the behaviour of Conatined Tabs. And I did notice a slightly different styling for overflow left and right buttons in WC compared to React. I could create a separate issue for that after doing further research as this a contined tabs specific issue.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide